Feeling Lucky
?
[#12209] - Fixing changed language strings in com_banners
- Fixed in Code Base
- 29 Sep 2016
- Medium
- Build: staging
- # 12209
- Diff
- Bakual:FixBannersValues
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue mentioned at #12178 (comment)
Basically my PR #8300 was incomplete and missed the values being displayed in the Banners -> Clients manager.
Summary of Changes
Changes the language strings in com_banners -> clients view to use the new ones.
Testing Instructions
- Delete the strings marked as deprecated in administrator/language/en-GB/en-GB.com_banners.ini:
COM_BANNERS_FIELD_VALUE_1="Unlimited"
COM_BANNERS_FIELD_VALUE_2="Yearly"
COM_BANNERS_FIELD_VALUE_3="Monthly"
COM_BANNERS_FIELD_VALUE_4="Weekly"
COM_BANNERS_FIELD_VALUE_5="Daily"
- Check the Clients Manager in the Banners view. You should see an untranslated string there.
- Apply PR and the strings are translated again.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-29 22:42:59 |
| Closed_By | ⇒ | wilsonge |