[#12201] - [com_mailto] Fix send duplicate email on internet explorer
- Fixed in Code Base
- 18 Nov 2017
- Medium
- Build: staging
- # 12201
- Diff
- vinespie:patch-1
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
- Pending JTracker/HumanTestResults Human Test Results: 2 Successful 2 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adding type "button" on marken button in form.
On Internet Explorer, you must specify the type as by default it is "submit" so calling "send" function of the controller is doubled.
Testing Instructions
1- Open joomla in internet explorer,
2- Open single article,
3- Clic on send email,
4- Fill out the form and click send,
5- You will receive the email in 2 copies
6- Apply patch
7- Open joomla in internet explorer,
8- Open single article,
9- Clic on send email,
10- Fill out the form and click send,
11- You will receive one email
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Labels |
Added:
?
|
||
I think greater than or equal version 8 but I'm not sure.
I tested on IE 11.
On w3.org, "submit" is the default value.
see https://www.w3.org/TR/html401/interact/forms.html#h-17.5
Just seems strange as this is old code
On 29 September 2016 at 10:56, Vincent Espié notifications@github.com
wrote:
On w3.org, "submit" is the default value.
see https://www.w3.org/TR/html401/interact/forms.html#h-17.5—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12201 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8U2g22U3xLQIQN5_vGVYWsPL1rnmks5qu4tigaJpZM4KJyBZ
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I thought the same thing when I was reporting this issue
| Category | Front End Components | ⇒ | Front End com_mailto Components |
I have tested this item
I have this error message when sending:
Could not instantiate mail function.
Email could not be sent.Could not instantiate mail function.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12201.
I have tested this item
tested unsuccessfully
from Meddah
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12201.
unsuccessfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12201.
I have tested this item
Since the type attribute is missing, it defaults to submit which submits the form in addition to the onclick submitting the form resulting in 2 messages.
Tested with IE 11.674.15063.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12201.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12201.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12201.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-18 15:58:37 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Which version of Internet Explorer?