? Failure

User tests: Successful: Unsuccessful:

avatar Tomas42
Tomas42
28 Sep 2016

Pull Request for Issue #12194 .

Summary of Changes

changed regex pattern to ignore additional parameters in hr system-readmore (additional parameters will be removed).

Testing Instructions

Works only when saving an article.

Documentation Changes Required

ignore additional parameters in the hr-system-readmore

avatar Tomas42 Tomas42 - open - 28 Sep 2016
avatar Tomas42 Tomas42 - change - 28 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2016
Category Libraries
avatar zero-24 zero-24 - change - 28 Sep 2016
Title
Update content.php
fix hr system-readmore not working with additional parameter
avatar zero-24 zero-24 - change - 28 Sep 2016
Title
Update content.php
fix hr system-readmore not working with additional parameter
avatar zero-24 zero-24 - edited - 28 Sep 2016
avatar zero-24 zero-24 - test_item - 29 Sep 2016 - Tested unsuccessfully
avatar zero-24
zero-24 - comment - 29 Sep 2016

I have tested this item ? unsuccessfully on

hmm it do not work here on my end.

I have sample data installed and that added to the "First blog post" your extended read more <hr id="system-readmore" style="width: 1013.75px; word-spacing: 0px;"> after that I can confirm it is broken but the same thing happen with that patch applyed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12199.

avatar Tomas42
Tomas42 - comment - 29 Sep 2016

@zero-24: Just to make sure: after installing the patch you opened the article again and saved it? because the splitting into intro/fulltext only works on saving the text.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12199.

avatar zero-24 zero-24 - test_item - 8 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 8 Oct 2016

I have tested this item successfully on 2ae3898

Ah ok thanks for the tip works now. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

avatar zero-24 zero-24 - change - 8 Oct 2016
Milestone Added:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Added:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Added:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Removed:
avatar hans2103 hans2103 - test_item - 4 Nov 2016 - Tested unsuccessfully
avatar hans2103
hans2103 - comment - 4 Nov 2016

I have tested this item ? unsuccessfully on 2ae3898

changed regex doesn't ignore the additional parameters, it removes them.

After save <hr id="system-readmore" style="width: 1013.75px; word-spacing: 0px;"> will be changed into <hr id="system-readmore" />

When you write ignore, I was expecting that it doesn't matter what kind of additional parameter you add.
When you write delete then this test is successful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

avatar Tomas42 Tomas42 - change - 8 Nov 2016
The description was changed
avatar Tomas42 Tomas42 - edited - 8 Nov 2016
avatar Tomas42
Tomas42 - comment - 8 Nov 2016

@hans2103: i added your hint to the description.
FYI: Joomla stores intro and full text in separate fields. The system-readmore-tag is created when editing an article to separate the fields again when the article is stored. The tag is never stored or used outside the editor. So any other parameters to this tag should be meaningless.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

avatar coolcat-creations
coolcat-creations - comment - 6 Dec 2016

i have no clue, it works as good before the patch like after. It removes the additional attributes, but isn´t that a wanted function?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jan 2017

I have tested this item ? unsuccessfully on 2ae3898

with and without PR a <hr id="system-readmore" style="width: 1013.75px; word-spacing: 0px;"> changes to <hr id="system-readmore" />


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Jan 2017 - Tested unsuccessfully
avatar mbabker
mbabker - comment - 11 Jan 2017

I don't see the issue with that. <hr id="system-readmore" /> doesn't actually get output on a page, it's used internally as a marker to split the introtext and fulltext values. IMO we shouldn't encourage using that specific <hr> as a styling element since the only place you ever see it is the backend editor.

avatar zero-24 zero-24 - change - 11 Jan 2017
Milestone Removed:
avatar Sieger66
Sieger66 - comment - 3 Mar 2017

Additional step to see and reproduce the issue #12194 quickly:

Chance the editor to "Editor-None" and save a article for example with insert of:

<hr id="system-readmore" style="width: 1013.75px; word-spacing: 0px;">
to create an introtext.

Show this article on front-end.

avatar Sieger66 Sieger66 - test_item - 3 Mar 2017 - Tested successfully
avatar Sieger66
Sieger66 - comment - 3 Mar 2017

I have tested this item successfully on 2ae3898


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

avatar franz-wohlkoenig franz-wohlkoenig - change - 6 Apr 2017
Status Pending Needs Review
avatar roland-d
roland-d - comment - 13 May 2017

@mbabker said that this isn't shown on the page, so what is the use of allowing additional attributes to the readmore tag?

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 May 2017
Priority Medium Very low
Status Needs Review Information Required
avatar brianteeman
brianteeman - comment - 20 May 2017

This change really makes no sense at all - why would someone go to the trouble of adding styling to something that is never displayed.

avatar Tomas42
Tomas42 - comment - 20 May 2017

@brianteeman I can not explain how she added the style. It was most likely unintentional, may be with some copy and paste or something like that.
As these styles are not useful and the current behavior (ignoring such a styled hr when splitting the article) is most likely unexpected I suggested this fix to ignore the additional stuff and split the article on the hr.
So the actual question is:
If a user added some style to the hr-tag, for whatever reason, why should joomla not use the styled hr-tag to split the editor content into intro and full text?
If someone know a reason please post here, otherwise it should be save to use the fix.

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Jun 2017
Status Information Required Needs Review
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jun 2017

set Status on "Needs Review".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

avatar Quy
Quy - comment - 4 Feb 2018

I don't see a use case/purpose to adding style to the readmore marker. If you have to, then add system-readmore css to custom.css file.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Feb 2018
Status Needs Review Information Required
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Apr 2018
Status Information Required Pending
avatar Quy Quy - change - 28 Apr 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-04-28 04:18:03
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2018
Closed_Date 2018-04-28 04:18:03 2018-04-28 04:18:04
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot
joomla-cms-bot - comment - 28 Apr 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/12199

avatar joomla-cms-bot joomla-cms-bot - close - 28 Apr 2018
avatar Quy
Quy - comment - 28 Apr 2018

Closing for reasons stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12199.

Add a Comment

Login with GitHub to post a comment