? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
28 Sep 2016

Summary of Changes

JApplicationHelper::parseXMLLangMetaFile has been deprecated in favour of JInstaller::parseXMLInstallFile for a long time now - so let's use the new method (they are exactly the same function)

Testing Instructions

Check the main backend page for the Language Component is unchanged

Note

This function has been removed in the Joomla 4.0 branch - so exta onus to get this done :P (Note we have now patched this exact thing in the 4.0 branch with #12644 - still worth doing for 3.7)

avatar wilsonge wilsonge - open - 28 Sep 2016
avatar wilsonge wilsonge - change - 28 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2016
Category Administration Components
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 28 Sep 2016
The description was changed
avatar wilsonge wilsonge - edited - 28 Sep 2016
avatar wilsonge wilsonge - change - 28 Sep 2016
The description was changed
avatar wilsonge wilsonge - edited - 28 Sep 2016
avatar wilsonge wilsonge - change - 28 Sep 2016
Milestone Added:
avatar RonakParmar RonakParmar - test_item - 10 Oct 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 10 Oct 2016

I have tested this item successfully on 371bbfb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12188.

avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Added:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Added:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Removed:
avatar wilsonge wilsonge - change - 31 Oct 2016
The description was changed
avatar wilsonge wilsonge - edited - 31 Oct 2016
avatar wilsonge wilsonge - change - 31 Oct 2016
The description was changed
avatar wilsonge wilsonge - edited - 31 Oct 2016
avatar zero-24 zero-24 - change - 31 Oct 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-10-31 16:18:17
Closed_By zero-24
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24
zero-24 - comment - 31 Oct 2016

Closing as obsolete now

avatar zero-24 zero-24 - change - 31 Oct 2016
Milestone Removed:
avatar wilsonge wilsonge - head_ref_deleted - 31 Oct 2016
avatar wilsonge
wilsonge - comment - 31 Oct 2016

Wait why? Why can we not also merge this into 3.7?

avatar wilsonge wilsonge - head_ref_restored - 31 Oct 2016
avatar zero-24
zero-24 - comment - 31 Oct 2016

3.7 == staging?

avatar wilsonge
wilsonge - comment - 31 Oct 2016

yup

avatar zero-24
zero-24 - comment - 31 Oct 2016

Ah ...

avatar zero-24 zero-24 - change - 31 Oct 2016
Status Closed New
Closed_Date 2016-10-31 16:18:17
Closed_By zero-24
avatar zero-24 zero-24 - reopen - 31 Oct 2016
avatar zero-24 zero-24 - reopen - 31 Oct 2016
avatar zero-24 zero-24 - change - 31 Oct 2016
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-31 21:01:23
Closed_By zero-24
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - merge - 31 Oct 2016
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - reference | c9243e7 - 31 Oct 16
avatar zero-24 zero-24 - merge - 31 Oct 2016
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - change - 31 Oct 2016
Milestone Added:
avatar zero-24
zero-24 - comment - 31 Oct 2016

Done. @wilsonge Thanks.

avatar wilsonge wilsonge - head_ref_deleted - 31 Oct 2016
avatar wilsonge
wilsonge - comment - 31 Oct 2016

Thankyou!

Add a Comment

Login with GitHub to post a comment