Joomla! Issue Tracker | Joomla! CMS #12183 - Clean up old code in cache.php file

Fixed in Code Base
12 Jan 2017
Medium
Build: staging
# 12183
Diff
csthomas:cache_php4_exc

Success

Success continuous-integration/drone the build was successful Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

csthomas
26 Sep 2016

Summary of Changes

Remove old php4 style to catch exception which currently is useless.
Add shorten version of ternary operators.
In lock and unlock methods direct call to handler.

Testing Instructions

Code review or real test:

Get latest staging Joomla.
Enable cache and set timeout to low value, for ex. 1 minute.
Go to frontend and check if pages work as before.
Go to backend and some cache items should be visible, clear only expired cache, clear all cache.

Votes

# of Users Experiencing Issue

1/1

Average Importance Score

4.00

3e06282 26 Sep 2016

Clean up in cache - part 1

csthomas - open - 26 Sep 2016

csthomas - change - 26 Sep 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 26 Sep 2016

Category

⇒

Libraries

joomla-cms-bot - change - 26 Sep 2016

Labels

Added: ?

csthomas - change - 28 Oct 2016

The description was changed

csthomas - edited - 28 Oct 2016

joomla-cms-bot - change - 28 Oct 2016

Labels

Added: ?

brianteeman - change - 29 Oct 2016

Labels

Removed: ?

csthomas - change - 4 Nov 2016

The description was changed

csthomas - edited - 4 Nov 2016

franz-wohlkoenig - comment - 11 Jan 2017

"Error-Reporting" set on "Maximum" got in Module "Main Menu" Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'JCache' does not have a method 'contains' in __/Joomla/libraries/joomla/cache/controller.php on line 69

mbabker - comment - 11 Jan 2017

If you're using patch tester then that'd be expected because of how the file is updated. You'll either need to apply the patch through git or wait for the branch this pull request comes from to be synchronized with the current staging branch.

franz-wohlkoenig - comment - 11 Jan 2017

@mbabker used Patchtester, got a "SHA"-Error at marking Test unsuccessfully.

e866b62 11 Jan 2017

Merge branch 'staging' into cache_php4_exc

0fc1832 11 Jan 2017

Add fix for contains()

csthomas - comment - 11 Jan 2017

After I clicked on "Update branch" I saw that the last changes use the old style.
Therefore I added the last commit. Test ready.

franz-wohlkoenig - comment - 11 Jan 2017

I have tested this item ✅ successfully on 0fc1832

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12183.}

franz-wohlkoenig - test_item - 11 Jan 2017 - Tested successfully