[#12169] - Replaced rand() with mt_rand() projectwide
- Fixed in Code Base
- 18 Oct 2016
- Medium
- Build: staging
- # 12169
- Diff
- frankmayer:mt_rand
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
mt_rand() is a drop-in replacement for rand() and should be preferred.
Since this is a drop-in replacement, it should not cause any problems to the existing codebase
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
?
|
||
| Category | ⇒ | Libraries External Library Plugins Front End Unit Tests |
| Labels |
Removed:
?
|
||
Oh, yes, thanks for reminding me - totally forgot about that. So should I do PR's against those external ones, or will you commit those changes?
@frankmayer fof 2.x (which is included in the core) is not active maintained anymore but you can try it at https://github.com/akeeba/fof/tree/fof-2.x
The framework don't use rand anymore: https://github.com/joomla-framework/session/blob/master/Session.php so if we get synced with that we are ok
The master branch for the session package is the 2.0 branch, there's a
1.x-dev branch which probably still has it since that's basically untouched
beyond having added the deprecation notices for 2.0 and the 3.4 security
fixes.
On Sunday, September 25, 2016, zero-24 notifications@github.com wrote:
@frankmayer https://github.com/frankmayer fof 2.x (which is included in
the core) is not active maintained anymore but you can try it at
https://github.com/akeeba/fof/tree/fof-2.xThe framework don't use rand anymore: https://github.com/joomla-
framework/session/blob/master/Session.php so if we get synced with that
we are ok? —
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12169 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoVjlwiRyMWzDkk_SAJWSicmTxOznks5qtqcYgaJpZM4KF68z
.
where is the 1.x-dev branch @mbabker ?
https://github.com/joomla-framework/session/branches/all I can just see a master and 2.0-dev branch
Oh, Nevermind. Getting confused with other repos.
On Sunday, September 25, 2016, zero-24 notifications@github.com wrote:
where is the 1.x-dev branch @mbabker https://github.com/mbabker ?
https://github.com/joomla-framework/session/branches/all I can just see a
master and 2.0-dev branch—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12169 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoexkJRKjCNXc5T4oN5-v_QwTKck2ks5qtrCUgaJpZM4KF68z
.
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12169.
I have tested this item
on review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12169.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12169.
| Labels |
Added:
?
|
||
Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release
| Labels |
Added:
?
Removed: ? |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-18 17:35:20 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Thanks @frankmayer for your PR. There are 3 places i have too revert your change as they are in 3party code.
The framework session package don't use rand in the last version: https://github.com/joomla-framework/session So if we pull the new session package we are ok. Thanks!