[#12147] - Content History: Missing check-out labels and Lang strings
- Closed
- 20 May 2017
- Medium
- Build: staging
- # 12147
- Diff
- infograf768:contenthistorycheckout
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When using Versions, the preview and compare popups do not display a translatable label for the Id of the user who checked out the item and the date for that check-out.
Instead, it uses the name of the fields, i.e. checked_out and checked_out_time.
Except for Newsfeeds where we do have a label, but no lang strings.
This gives (fr interface):
After this patch, we will get:
New lang strings:
JGLOBAL_FIELD_CHECKEDOUT_LABEL="Id of the User who Checked-out"
// we could put here: "Checked-out by"
JGLOBAL_FIELD_CHECKEDOUT_TIME_LABEL="Date of the Check-out"
// or "Check-out date" ?
@brianteeman
strings OK?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Tags Language & Strings Front End |
| Labels |
Added:
?
?
|
||
zero-24
- | Milestone |
Added: |
||
Checked with 3.7 and com_newsfeeds and I do not see an untranslated field for checkout
In general I do not see the need for the checkout time or user to be displayed in the version info
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12147.
Looks like there are changes in 3.7.
These fields are no more displayed, except if I mistake in my new tests.
Code is there though in the models/forms/newsfeed.xml and similar xmls:
<field
name="checked_out"
type="Text"
label="JGLOBAL_FIELD_CHECKEDOUT_LABEL"
description="JGLOBAL_FIELD_CHECKEDOUT_DESC"
size="6"
readonly="true"
filter="unset"
/>
<field
name="checked_out_time"
type="Text"
label="JGLOBAL_FIELD_CHECKEDOUT_TIME_LABEL"
description="JGLOBAL_FIELD_CHECKEDOUT_TIME_DESC"
size="6"
readonly="true"
filter="unset"
/>
and elsewhere it is:
<field
name="checked_out"
type="hidden"
filter="unset"
/>
<field
name="checked_out_time"
type="hidden"
filter="unset"
/>
Checked in 3.6.3 as well and dont see the checked out fields being displayed either
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12147.
@infograf768 so do we need this PR - we both cant see the checked out values in the versions display and there really is no reason to add it as it has no value for versions
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12147.
| Status | Pending | ⇒ | Information Required |
| Labels | |||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@inforgraf768 can we close this
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12147.
| Milestone |
Removed: |
||
will look at it again when i have some time.
I am closing this at this time. its been 5 months since the last comment and it would appear to not be used. it can always be reopened if needed
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-20 12:31:46 |
| Closed_By | ⇒ | brianteeman |
| Category | Administration Components com_tags Language & Strings Front End | ⇒ | Administration com_categories com_contact com_content com_finder com_menus com_newsfeeds com_tags com_users Language & Strings Front End Components |
Note: Languages are frozen for 3.6.3. Therefore this woud be for next version.