?
Failure
-
Success
continuous-integration/drone
the build was successful
Details
-
Failure
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
User tests:
Successful:
Unsuccessful:
Summary of Changes
- Remove conditionals for returning
JError::raise*
response or throwing exceptions in favor of throwing exceptions for many library functions
- Remove returning
JError::raise*
response in favor of throwing exceptions in other library functions
- Remove silent discarding of errors when retrieving the menu, pathway, and router objects via the application classes
- Have Redis cache throw exceptions as noted in code
Testing Instructions
Review
Documentation Changes Required
Error handling expectations are changed from handling legacy JError
behaviors to catching exceptions in noted places.
mbabker
-
open
-
22 Sep 2016
mbabker
-
change
-
22 Sep 2016
joomla-cms-bot
-
change
-
22 Sep 2016
joomla-cms-bot
-
change
-
22 Sep 2016
zero-24
-
change
-
22 Sep 2016
wilsonge
-
change
-
23 Sep 2016
Status |
Pending |
⇒ |
Fixed in Code Base |
Closed_Date |
0000-00-00 00:00:00 |
⇒ |
2016-09-23 08:40:13 |
Closed_By |
|
⇒ |
wilsonge |
wilsonge
-
close
-
23 Sep 2016
wilsonge
-
merge
-
23 Sep 2016
Add a Comment
Login with GitHub to post a comment