? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
22 Sep 2016

This removes the dependency of JControllerLegacy on JObject.

Various extensions needed tweaks so that error messages are set directly with setMessage rather than proxying with setError('foo') then calling $this->setMessage($this->getError())

avatar wilsonge wilsonge - open - 22 Sep 2016
avatar wilsonge wilsonge - change - 22 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 22 Sep 2016

how to test @wilsonge ?

avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2016
Category Libraries Administration Components Media Manager Tags Front End Libraries
avatar wilsonge
wilsonge - comment - 23 Sep 2016

You basically need to test every view of every controller :/ They should all work without any errors

avatar wilsonge
wilsonge - comment - 23 Sep 2016

Rebased for the unit tests

avatar wilsonge wilsonge - change - 23 Sep 2016
The description was changed
avatar wilsonge wilsonge - edited - 23 Sep 2016
avatar wilsonge wilsonge - change - 24 Sep 2016
Title
Make JControllerLegacy no longer extend JObject
[Joomla 4] Make JControllerLegacy no longer extend JObject
avatar wilsonge wilsonge - edited - 24 Sep 2016
avatar wilsonge
wilsonge - comment - 3 Oct 2016

Rebased again due to conflicts

avatar andrepereiradasilva andrepereiradasilva - test_item - 3 Oct 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Oct 2016

I have tested this item successfully on 3d0192f

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12142.

avatar wilsonge wilsonge - change - 5 Oct 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-05 20:25:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Oct 2016
avatar wilsonge wilsonge - merge - 5 Oct 2016
avatar wilsonge wilsonge - close - 5 Oct 2016
avatar wilsonge wilsonge - change - 5 Oct 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment