[#12118] - Add big red warning flag that the app classes are very tightly coupled to sessions in JFactory
- Fixed in Code Base
- 21 Sep 2016
- Medium
- Build: staging
- # 12118
- Diff
- mbabker:session-warning
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adds a big red warning flag that Joomla has a very tight internal dependency to the global singleton factory and that any attempt to ever change this code results in things crashing and burning catastrophically because of the crappy tight internal dependency to the global singleton factory.
Testing Instructions
Review
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Travis is not happy because of too long lines :)
| Status | Pending | ⇒ | Ready to Commit |
RTC on review. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12118.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-21 13:18:07 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I love the description of this PR
When using imTranslator (Google proposal) it gives in French:
Ajoute un gros avertissement drapeau rouge que Joomla a une dépendance interne très serrée à l'usine mondiale de singleton et que toute tentative de jamais changer ce code résultats dans les choses qui se brisent et brûlant catastrophiquement en raison de la dépendance interne étanche crappy à l'usine mondiale de singleton.
and reverse translation gives:
Put a big red flag warning that Joomla has an internal arm tightly to the World singleton factory and that any attempt to change this ever results in code things crashing and burning catastrophically because of the tight inner arm to the crappy World factory singleton.
ROTFLOL