[#12092] - Config Search - blue bar with Fieldset Description
- Closed
- 4 Jan 2018
- Medium
- Build: staging
- # 12092
- Diff
- pe7er:info-label-options-search
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Most Component Configuration Options have under the option tab a blue bar with a description
Summary of Changes
This PR changes the tab option name from [Component] to [Search Settings] and adds a blue bar with description.
Testing Instructions
Before the PR:
backend: System > Global Configuration > (in Left menu) Search > [Component]
After the PR:
backend: System > Global Configuration > (in Left menu) Search > [Search Settings]
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings |
| Labels |
Added:
?
?
|
||
Too early in the morning. I see that you have done that already. Thank you.
Yes, I created a PR per component because that way it will be easier to test, to change (because some language string descriptions could probably be improved) and if ok, to merge with core (without merge conflicts).
It's fine and a good method. I just replied before my first coffee :)
I like the change for the tab but I think the "blue bar" is not needed at least in this case
I have tested this item
Works :) although will need translating!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12092.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12092.
@brianteeman please look at this so we can go RTC
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12092.
The blue bar is not needed - you just added some meaningless text in order to justify adding th blue bar - my 2c
franz-wohlkoenig
- | Status | Pending | ⇒ | Needs Review |
| Category | Administration Components Language & Strings | ⇒ | Administration com_search Language & Strings Components |
The blue bar/text is stating the obvious and adds no additional information so I agree with Brian/Robert that it is not necessary in this case.
Closed for the reasons stated above
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-04 17:21:59 |
| Closed_By | ⇒ | brianteeman |
There are several components like this. It would be great if you could fix
them all.