[#12079] - Enable the JS Tests as they are fixed now
- Fixed in Code Base
- 19 Sep 2016
- Medium
- Build: staging
- # 12079
- Diff
- zero-24:jstests_travis
- Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details
- Success continuous-integration/drone the build was successful Details
User tests: Successful: Unsuccessful:
Summary of Changes
Don't allow JS Tests to fail on travis
Testing Instructions
See travis
Documentation Changes Required
none
| Labels |
Added:
?
?
|
||
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-19 15:38:35 |
| Closed_By | ⇒ | wilsonge |
It depends. At the Joomladay Germany @yvesh and myself worked on some docker containers to let PHPCS and PHPUnit run on drone. There is only one missing pice. We need drone 0.5 to build pipelines (we use 0.4 atm). So if we can fix this we could drop travis for drone and could also add a package build step and could then get rid of jenkins. The plan is to figure it out very soon, might discuss it within the automated testing team and make a proposal for the PLT.
To keep a long story short, I would enable the JS test only if we remove the drone CI what is an option because we know now what we need to know.
I'm merging this. But as we are running drone do we really want to run these on travis and drone? Or should be leave them on drone and just remove travis tests?