[#12062] - [RFC] uncouple guest_usergroup from com_users
- Closed
- 23 Jul 2017
- Medium
- Build: staging
- # 12062
- Diff
- andrepereiradasilva:guest-no-depend
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR aims to uncomple guest_usergroup param from com_users and add it to global config instead.
Testing Instructions
- Code review
- Neeeds to be tested on install AND on update
- For install (test several sample data - since they have different guest user groups)
- Apply patch, delete configuration.php, refresh page, install Joomla
- Go to global config and make sure the guest usergroup selected is the "Guest" one
- Try to change the guest user group and confirm its working fine
- For update
- [TO DO] If positive comments
Note: Use the most recent version of the patchtester https://github.com/joomla-extensions/patchtester/releases/download/3.0.0-alpha2/com_patchtester.zip if you have memory issues installing the patch
Documentation Changes Required
Any docs that shows you to set the default guest usergroup needs to be updated.
Notes
-
It should be B/C. But please check.
-
Besides from a architucture point it seems better this way, this should speed all guest non com_users pages load by 2 to 4 ms and less ~0.2 MB memory because doesn't need to get the param from com_users component. But that can be added again later if other componet uses JComponetHelper (ex: com_languages)
-
I didn't test the update process yet, only the new installation process, if comments are favorable to this change will test it and, if needed, make necessary changes.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Components Language & Strings Installation SQL Postgresql MS SQL Libraries |
| Labels |
Added:
?
?
|
||
| Labels |
Removed:
?
?
|
||
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
|
||
This doesnt seem correct to me. It might work with the sample data but we have no way of knowing how this is really being used in live sites. They might have heavily customised this group
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12062.
As said in pr description the update part is not tested yet because this is an rfc.
Anyway the goal is, on update, fetch the current guest usergroup valid an use it to populate the new configuration value.
The update part of this is fine. Actually it's much cleaner than the last time we moved a config from component to global (the text filters, which was done entirely by SQL statements). The only way it fails is if the component parameters can't be read, which if the update gets that far without being able to read component parameters would be a pretty big miracle.
This PR needs a new owner or it will have to be closed as abandoned.
| Status | Pending | ⇒ | Information Required |
| Category | Administration Components Language & Strings Installation SQL Postgresql MS SQL Libraries | ⇒ | Administration com_admin com_config com_users Language & Strings Installation SQL Postgresql MS SQL Libraries Unit Tests Components |
If this PR get no Response, it will be closed at 23th July 2017.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-23 08:22:36 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2017-07-23 08:22:36 | ⇒ | 2017-07-23 08:22:37 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
closed as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12062.
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/12062
@mbabker do you agree?
If so, can you help with the unit tests failing?