User tests: Successful: Unsuccessful:
Same patch as #11935 but towards 3.7.x
See there for instructions.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Components Language & Strings Front End Layout |
Labels |
Added:
?
?
|
Labels |
Added:
?
|
Yeah, was patchtester, as I said. It does not feel well when there is something to correct, even if it is only in an xml...
Report it as a bug then
Status | Pending | ⇒ | Ready to Commit |
Setting back to RTC as it was just a matter of adapting to 3.7
The layout is only aimed at articles (infoblock and list).
The choice should not depend on the template but on the user if he wants flags or sef code.
Patches welcome for anything else.
See infograf768#43 for the proposed changes.
The layout is only aimed at articles (infoblock and list).
Then put the layout in com_content's folder. There have already been crap decisions made putting extension specific layouts in the global layouts directory, JLayout
supports a layouts
directory at the component level so if it's really that hard locked to a single component that's where it should live.
Then put the layout in com_content's folder. There have already been crap decisions made putting extension specific layouts in the global layouts directory, JLayout supports a layouts directory at the component level so if it's really that hard locked to a single component that's where it should live.
The info_block layout folder is in the global layouts/joomla/content/ folder. Wrong or not, the aim of this PR is not to refactor that part.
@Bakual
Thanks, I used your code and kept the choice between sef label and flags.
This has to be tested again.
@alexgarel
@zero-24
@alikon
Status | Ready to Commit | ⇒ | Pending |
Setting back to pending.
Labels |
Removed:
?
|
kept the choice between sef label and flags.
Did you try if it works when you add that parameter to menuitem and article as well? In theory it should work and I'm sure the request will come sooner or later.
I guess you mean in admin?
In fact I do not understand what you mean.
You added two new parameters. show_associations
is added to component config, view (menu item) configs and article options. The other param flag
you only added to component config. However it should work fine when you add that one to the other places as well.
You added two new parameters. show_associations is added to component config, view (menu item) configs and article options. The other param flag you only added to component config. However it should work fine when you add that one to the other places as well.
I did do it on purpose. The UI should be consequent: or we use for all or not. Deciding that it would show flags in blogs and sef icon in featured makes no sense imho.
I did do it on purpose.
Ok.
I have tested this item
Thanks, looks great now.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC, at last...
@wilsonge You may now merge in 3.7. Thanks
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-18 13:39:31 |
Closed_By | ⇒ | wilsonge |
Thanks JM :)
Labels |
Removed:
?
|
No problem with the merge now