? ? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
15 Sep 2016

Same patch as #11935 but towards 3.7.x
See there for instructions.

avatar infograf768 infograf768 - open - 15 Sep 2016
avatar infograf768 infograf768 - change - 15 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2016
Category Administration Components Language & Strings Front End Layout
avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2016
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 15 Sep 2016

No problem with the merge now

avatar brianteeman brianteeman - change - 15 Sep 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 15 Sep 2016

Yeah, was patchtester, as I said. It does not feel well when there is something to correct, even if it is only in an xml...

avatar brianteeman
brianteeman - comment - 15 Sep 2016

Report it as a bug then

avatar infograf768 infograf768 - change - 15 Sep 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 15 Sep 2016

Setting back to RTC as it was just a matter of adapting to 3.7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12042.

avatar infograf768
infograf768 - comment - 15 Sep 2016

The layout is only aimed at articles (infoblock and list).
The choice should not depend on the template but on the user if he wants flags or sef code.
Patches welcome for anything else.

avatar Bakual
Bakual - comment - 15 Sep 2016

See infograf768#43 for the proposed changes.

avatar mbabker
mbabker - comment - 15 Sep 2016

The layout is only aimed at articles (infoblock and list).

Then put the layout in com_content's folder. There have already been crap decisions made putting extension specific layouts in the global layouts directory, JLayout supports a layouts directory at the component level so if it's really that hard locked to a single component that's where it should live.

avatar infograf768
infograf768 - comment - 16 Sep 2016

Then put the layout in com_content's folder. There have already been crap decisions made putting extension specific layouts in the global layouts directory, JLayout supports a layouts directory at the component level so if it's really that hard locked to a single component that's where it should live.

The info_block layout folder is in the global layouts/joomla/content/ folder. Wrong or not, the aim of this PR is not to refactor that part.

avatar infograf768
infograf768 - comment - 16 Sep 2016

@Bakual
Thanks, I used your code and kept the choice between sef label and flags.

This has to be tested again.
@alexgarel
@zero-24
@alikon

avatar infograf768 infograf768 - change - 16 Sep 2016
Status Ready to Commit Pending
avatar infograf768
infograf768 - comment - 16 Sep 2016

Setting back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12042.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Sep 2016
Labels Removed: ?
avatar Bakual
Bakual - comment - 16 Sep 2016

kept the choice between sef label and flags.

Did you try if it works when you add that parameter to menuitem and article as well? In theory it should work and I'm sure the request will come sooner or later.

avatar infograf768
infograf768 - comment - 16 Sep 2016

I guess you mean in admin?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12042.

avatar infograf768
infograf768 - comment - 16 Sep 2016

@Bakual

In fact I do not understand what you mean.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12042.

avatar Bakual
Bakual - comment - 16 Sep 2016

You added two new parameters. show_associations is added to component config, view (menu item) configs and article options. The other param flag you only added to component config. However it should work fine when you add that one to the other places as well.

avatar infograf768
infograf768 - comment - 16 Sep 2016

You added two new parameters. show_associations is added to component config, view (menu item) configs and article options. The other param flag you only added to component config. However it should work fine when you add that one to the other places as well.

I did do it on purpose. The UI should be consequent: or we use for all or not. Deciding that it would show flags in blogs and sef icon in featured makes no sense imho.

avatar Bakual
Bakual - comment - 16 Sep 2016

I did do it on purpose.

Ok.

avatar Bakual Bakual - test_item - 16 Sep 2016 - Tested successfully
avatar Bakual
Bakual - comment - 16 Sep 2016

I have tested this item successfully on 66f272b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12042.

avatar infograf768
infograf768 - comment - 16 Sep 2016

@Bakual
Done.

avatar Bakual
Bakual - comment - 16 Sep 2016

Thanks, looks great now. ?

avatar infograf768 infograf768 - alter_testresult - 16 Sep 2016 - Bakual: Tested successfully
avatar alikon alikon - test_item - 17 Sep 2016 - Tested successfully
avatar alikon
alikon - comment - 17 Sep 2016

I have tested this item successfully on 19941bb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12042.

avatar infograf768 infograf768 - change - 17 Sep 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 17 Sep 2016

RTC, at last...

@wilsonge You may now merge in 3.7. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12042.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 18 Sep 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-18 13:39:31
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 18 Sep 2016

Thanks JM :)

avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment