? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
13 Sep 2016

Summary of Changes

Improve ACL asset preloading performance/memory consumption.

Before

image

After

image

Testing Instructions

  1. Code review
  2. Use latest staging and apply patch
  3. Turn on debug mode and debug system plugin
  4. Check the profiler in several frontend/backend pages and notice the more ACL checks are done the more is the performance improvements.
  5. Check if ACL permissions work fine (do multiple tests). Make sure there are no ACL breachs after this.

The performance improvements are particular higher when logged in with a non-root user and a lot of modules (since in this cases there are a lot of ACL checks).

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 13 Sep 2016
avatar andrepereiradasilva andrepereiradasilva - change - 13 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2016
Category Libraries
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Sep 2016

Just an additional info.
This is the performance/memory usage difference with a logged (non super user) joomla clean test sample data install frontend home page.

Before

image

After

image

avatar 810 810 - test_item - 13 Sep 2016 - Tested successfully
avatar 810
810 - comment - 13 Sep 2016

I have tested this item successfully on 040f069


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12028.

avatar alikon alikon - test_item - 17 Sep 2016 - Tested successfully
avatar alikon
alikon - comment - 17 Sep 2016

I have tested this item successfully on 040f069


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12028.

avatar zero-24 zero-24 - change - 17 Sep 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 17 Sep 2016

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12028.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Sep 2016

should go to 3.7.x IMO

avatar zero-24
zero-24 - comment - 17 Sep 2016

Done thanks!

avatar mbabker mbabker - change - 17 Sep 2016
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - change - 18 Sep 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-18 15:39:29
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Sep 2016
avatar wilsonge wilsonge - merge - 18 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 18 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment