? ? Success

User tests: Successful: Unsuccessful:

avatar ShuraChow
ShuraChow
13 Sep 2016

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Documentation Changes Required

avatar ShuraChow ShuraChow - open - 13 Sep 2016
avatar ShuraChow ShuraChow - change - 13 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2016
Category Plugins Front End
avatar wilsonge
wilsonge - comment - 13 Sep 2016

What PHP Notice is this fixing and how do you reproduce it. It's not obvious to me why reversing these arguments fixes anything

avatar brianteeman brianteeman - change - 13 Sep 2016
Labels Added: ?
avatar ShuraChow
ShuraChow - comment - 14 Sep 2016

sorry, please see latest commit.
$bars[0] might be empty

avatar photodude
photodude - comment - 15 Sep 2016

@ShuraChow Please fill out the fields in your PR

  • Pull Request for Issue ______
  • Summary of Changes
  • Testing Instructions
  • Documentation Changes Required

Filling out those fields will speed review and testing of your PR

Look at the other PR's in the project if you need help knowing what is expected or examples on how to fill these fields out.

avatar brianteeman brianteeman - change - 16 Sep 2016
Status Pending Information Required
avatar brianteeman
brianteeman - comment - 21 Sep 2016

@shurachow This will be closed in a few days if the required information is not provided


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12025.

avatar brianteeman
brianteeman - comment - 9 Oct 2016

As stated above this is now closed. It can always be reopened if the requested information is provided


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12025.

avatar brianteeman brianteeman - change - 9 Oct 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-10-09 11:59:48
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Oct 2016

Add a Comment

Login with GitHub to post a comment