[#12020] - Fix no menu item pages giving wrong links
- Fixed in Code Base
- 13 Sep 2016
- Medium
- Build: 3.7.x
- # 12020
- Diff
- wilsonge:routing_no_menu_item_fix
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9950 .
Summary of Changes
Fixes bug of URL's when you are on a page with no active menu item. Hat tip to @joeforjoomla for pointing me to the right place!
Testing Instructions
Navigate to a page with no menu item (e.g. http://localhost/~george/joomla-cms/component/tags) and try and use a menu item. Note that before patch they either contain an incorrect URL or simply the wrong URL. They now contain the correct URL
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
|
||
Unit tests fixed. Code style fixed. And unit test added to prevent regressions :)
cool - thanks - is this the same code i tested earlier?
On 12 September 2016 at 22:27, George Wilson notifications@github.com
wrote:
Unit tests fixed. Code style fixed. And unit test added to prevent
regressions :)—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12020 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TSz_aW4r-Vg22jGWAexoNeqpk_Oks5qpcOxgaJpZM4J6_9B
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Not quite. I made a small simplification tweak. But effectively it's the same thing. It can't hurt to test it again I guess
OK - will revert the manual patch and test this
On 12 September 2016 at 22:31, George Wilson notifications@github.com
wrote:
Not quite. I made a small simplification tweak. But effectively it's the
same thing. It can't hurt to test it again I guess—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12020 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UATgDk6gYjEnr2KtAhHhA-6yc0Gks5qpcTPgaJpZM4J6_9B
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Thanks :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12020.
I have tested this item
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC. Thanks guys :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12020.
| Labels |
Added:
?
|
||
Thanks to you George :)
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-13 05:47:23 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Hmm it looks like there are unittests fails and a CS problem. ;)