User tests: Successful: Unsuccessful:
There should be no visual improvements or negative views.
This pr can be merged by checking code
Status | New | ⇒ | Pending |
Category | ⇒ | Templates (admin) Administration Templates (site) Front End |
Labels |
Added:
?
?
|
Editing bootstrap files is not an option
On 12 September 2016 at 14:12, Joomla! CMS Bot notifications@github.com
wrote:
Please add more information to your issue. Without test instructions
and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application
https://github.com/joomla/jissues.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12018 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fUboVBfBXzO-wJmIaiooWorJP7dks5qpU-7gaJpZM4J6kTm
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
why not, Bootstrap 2x is deprecated. Its just a small issue. I can remove the fix on bootstrap file.
You know what? We've already core hacked or forked so many other libraries, INCLUDING Bootstrap. Why bother continuing to treat it like sacred ground that can't be touched when the project has already proven that it can't pull a third party dependency without hacking it?
Other people may be using the bootsstrap.css in their extensions
On 12 September 2016 at 14:24, Michael Babker notifications@github.com
wrote:
You know what? We've already core hacked or forked so many other
libraries, INCLUDING Bootstrap. Why bother continuing to treat it like
sacred ground that can't be touched when the project has already proven
that it can't pull a third party dependency without hacking it?—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12018 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bqo-R3GiN7fiZLi6QPNL8DFG1Ctks5qpVKFgaJpZM4J6kTm
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Other people may be using Chosen in their extensions yet 08f116c was merged with all required hacks for the sake of backward compatibility (so in effect forking the project).
Our hacks in these libraries have already caused enough issues. joomla/joomla-websites#569 is one example of a perceived bug because there is a major behavioral difference between the Joomla! Bootstrap Framework and the Twitter Bootstrap Framework.
This is NOT a duplicate, it's a fallback. If the browser doesn't support rgba()
, it will fallback to #ccc
Same applies for things like background gradients, for example:
background: #1e5799;
background: linear-gradient(to bottom, #1e5799 0%,#7db9e8 100%);
So no, this is not an issue at all.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-12 14:26:19 |
Closed_By | ⇒ | 810 |
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.