[#12013] - Fix error in mergeHeadData method for html document
- Fixed in Code Base
- 18 Oct 2016
- Medium
- Build: staging
- # 12013
- Diff
- csthomas:hhvm_fix_document_html
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR does two things:
- extend tests in order to display the error in php Travis tests.
- fix the error generated by
array_uniquefunction
Testing Instructions
How to reproduce notices?
$html = new JDocumentHtml();
$html->addHeadLink('http://www.example.com', 'Start');
$html->addHeadLink('http://www.example.com/end', 'End');
$html->mergeHeadData($html->getHeadData());generates several:
PHP Notice: Array to string conversion in /home/[...]/libraries/joomla/document/html.php on line 222
And $html->_links contain only first link.
After patch this notice disappears and links contain all links.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
As you can see it is expected.
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Title |
|
||||||
This is a simple fix + extend test. if no one is interested?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12013.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12013.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12013.
| Labels |
Added:
?
|
||
Awesome, glad to see someone found a solution without needing to wait for HHVM to fix the special casing for <= 1 elements with array_merge()
Note: we would have had the same error in php if the top level of the nested array had just one more element
https://3v4l.org/vHUAv
Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-18 17:32:45 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Why do we have an array here. Is it expected or is it a bug in the test data?