? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
11 Sep 2016

Pull Request after Commit fc41a23

Summary of Changes

Some CS after the last commit: fc41a23

Testing Instructions

  • Code review
  • double check that #11246 is not broken.
  • check the isis pagenavigation on desktop and mobile.

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 11 Sep 2016
avatar zero-24 zero-24 - change - 11 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2016
Category Templates (admin) Administration
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2016
Labels Added: ?
avatar zero-24 zero-24 - change - 11 Sep 2016
Title
Cs 37x
fix some cs issues in the 3.7. branch
avatar zero-24 zero-24 - edited - 11 Sep 2016
avatar wilsonge
wilsonge - comment - 11 Sep 2016

One test should be sufficient for this :)

avatar brianteeman
brianteeman - comment - 11 Sep 2016

Looks like a lot more than codestyle to me. CS is changing tabs to spaces and new lines. This is different code

avatar bertmert
bertmert - comment - 12 Sep 2016

As an aside: Lots of these CS issues and code are taken over 1:1 from /layouts/pagination/link.php and links.php. Should be fixed there, too(?)

avatar zero-24 zero-24 - change - 12 Sep 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-09-12 06:20:36
Closed_By zero-24
avatar zero-24 zero-24 - close - 12 Sep 2016

Add a Comment

Login with GitHub to post a comment