[#12005] - fix problem with accordions using parent option
- Fixed in Code Base
- 2 Apr 2017
- Medium
- Build: staging
- # 12005
- Diff
- Minei3oat:AccordionParentFix
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11956 .
Summary of Changes
Now accordion-toggle of slides which where collapsed by opening an other slide in an accordion with the option parent set to the id of the accordion gets the class collapsed.
Testing Instructions
For making the testing simple I've created a component :).
Download and install https://github.com/Minei3oat/com_test .
The component contains a single view with two accordions which contains five slides. The style of the component will show accordion-toggles with class collapsed green and without red. This makes it easy to see the difference.
Now open a slide which is not open. The open slide will close, but its accordion-toggle don't gets the class collapsed as it gets when you close the slide yourself.
After applying this patch the class collapsed will get asseigned.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
After installation of com_test created a new Menu item type Accordion test. After Patch new clicked Accordeon get Red, Accordeon Tab before changed from Red to Green.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12005.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12005.
I tested this succesfully.
I made a menu-item after installing the component.
Before apliing PR the style of the accordion header become red after reading the article. After appliing the PR the accorion header become green after reading the article.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12005.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-02 19:14:26 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Can you have a look into the cs issues?
https://travis-ci.org/joomla/joomla-cms/jobs/159032130
Also can you add a clean line befor the if?