[#12003] - remove unneeded space from btn-group/radio/checkboxes
- Fixed in Code Base
- 11 Jan 2017
- Medium
- Build: staging
- Easy Test
- # 12003
- Diff
- Minei3oat:betterForm
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In vertical from there was unneeded space between the label and some controls (radio, checkboxes) under it.
Removed padding-top of btn-group to align with label.
Added 2px padding-top to btn-group-yesno in isis to compensate 2px less padding-top of each button to have the buttons aligned with the label.
Testing Instructions
Look at some vertical forms in backend (Isis) and frontend (Protostar):
There is 5px more space between the label and the radio (btn-group as well because it is type radio) / checkboxes field than other fields. After aplying this PR the additional space should disapear.
Look at some horizontal forms in backend (Isis) and frontend (Protostar):
Before the PR the text of btn-group is not aligned to the text of the label. After aplying this PR it should be.
Documentation Changes Required
none
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Templates (admin) Administration Templates (site) Front End |
| Labels |
Added:
?
|
||
Hm, in the backend there is a lot of form-vertical in from-horizontal. This is ugly because form-horizontal adds some style for horizontal forms which aren't removed by form-vertical.
The from-vertical is created by https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/global.php#L47. So all components which uses JLayoutHelper::render('joomla.edit.global', $this); in a form-horizontal produce this problem.
@Minei3oat Please include some before and after screenshots. That will help you to get testers for this
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
I hope the image helps.
Well at least I have a clue what you were talking about now. Hopefully others will as well.
I am not a CSS expert but I see that you have added 0px and I was under the impression that you don't use a unit when the value is 0
I have tested this item
Thanks for the image - it made it easy for me to confirm the issue you were describing and to confirm that this PR fixed the issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
It seems equal weather to use a unit for zero values or not. It is used both in the templates' less files. Since Bootstrap uses no units on zero values I've dropped them.
I checked and technically its optional but it seems to be preferred to
remove it
https://www.w3.org/TR/css3-values/#lengths
On 14 October 2016 at 20:42, Minei3oat notifications@github.com wrote:
It seems equal weather to use a unit for zero values or not. It is used
both in the templates' less files. Since Bootstrap uses no units on zero
values I've dropped them.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12003 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TRjeoCq1FfFFStk-gPMRKF1L0V7ks5qz9sfgaJpZM4J5z9A
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
| Easy | No | ⇒ | Yes |
| Labels |
Removed:
?
|
||
This patch reverts the new bright green color too ?
i like the brighter one more...
beside then tested successfully on the heightchange...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
This pull request changes no colors in the less files. But other pull requests submitted after I created mine have changed the colors and I didn't updated this one. So the templates css-files in this pull request are compiled with the old colors.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
@Minei3oat can you please look at the conflicts?
administrator/templates/isis/css/template-rtl.css
administrator/templates/isis/css/template.css
administrator/templates/isis/less/template.less
I hope, I resolved the conflicts correct
I have tested this item
Tested with Joomla! 3.7.0-alpha1:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
I have tested this item
I have checked the issue before the patch
And successfully tested with the patch!
Thanks @Minei3oat !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
@franz-wohlkoenig I've tested this PR with 3.7.0 Alpha 1 in the browsers IE 11, Firefox 45 and Google Chrome 55 but I couldn't find a problem.
I have tested this item
Tested on a clean Installation works, my fault.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-11 19:36:13 |
| Closed_By | ⇒ | rdeutz |
Usually we don't change anything in 3rd party files.
media/jui/less/forms.lessis coming from Bootstrap and is used by 3rd party templates, thus it has an effect beyond our core templates.Try to do the fix in the Protostar/Isis template files.