Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
25 Oct 2011

Simply remove a $Id$ from metadata.xml now that hosting is git based and no longer using svn:keywords

avatar PhilETaylor PhilETaylor - open - 25 Oct 2011
avatar PhilETaylor
PhilETaylor - comment - 25 Oct 2011

I have a lot more small tidy up commits I want to submit, along with their tests, but lets see how these two pull requests get on through "the system" first...

avatar infograf768
infograf768 - comment - 26 Oct 2011

Please post on Joomlacode tracker. We are not using github yet for CMS tracker/patches.

avatar PhilETaylor
PhilETaylor - comment - 26 Oct 2011

Ha, ok then, I hope that will change soon :-) Pull requests are very cheap and can be reviewed, discussed and merged with very little hard work :-) Creating patches for svn and using joomlacode, as you know, is a hell of a lot more work :-)

Keep up the great work.
Phil.

avatar PhilETaylor PhilETaylor - close - 26 Oct 2011
avatar elkuku
elkuku - comment - 26 Oct 2011

I believe we are all waiting impatiently that this is going to happen...

avatar PhilETaylor
PhilETaylor - comment - 26 Oct 2011

I think it will radically change the quality of code and lower the barriers to entry for contributing. For example, this pull request I made without ever downloading the code, I did it all in github as I was browsing, people can instantly see the diff and could merge it easily (if they wanted) or comment or reject it.

For those of use using git and github daily we are already converts - I guess it takes time to convert the masses...

avatar elinw
elinw - comment - 26 Oct 2011

Hi for now can you just please use the playground.

avatar PhilETaylor
PhilETaylor - comment - 26 Oct 2011

This was not a test, it was a really contribution, but it seems you are not accepting or geared up for that at the moment :-) I know how to use git and GitHub so I don't need to "play" :-)

On 26 Oct 2011, at 22:14, elinw reply@reply.github.com wrote:

Hi for now can you just please use the playground.

Reply to this email directly or view it on GitHub:
#12 (comment)

avatar elinw
elinw - comment - 26 Oct 2011

But the point is to make stuff available so others can practice and learn since we will no move until everyone feels comfortable. in the meantime, correct as posted all over, please don't use this for real work yet unless is ti a 2.5 feature.

avatar chdemko chdemko - reference | - 21 Nov 11
avatar andreatarr andreatarr - reference | - 27 Aug 12
avatar juliopontes juliopontes - reference | - 6 Mar 13
avatar dextercowley dextercowley - reference | - 11 Apr 13
avatar infograf768 infograf768 - reference | 2d33d95 - 25 Oct 14
avatar N6REJ N6REJ - reference | c2403b5 - 6 Jan 15
avatar N6REJ N6REJ - reference | 71a8621 - 6 Jan 15
avatar N6REJ N6REJ - reference | 91f17d6 - 6 Jan 15

Add a Comment

Login with GitHub to post a comment