[#11995] - Grid within well changed to row-fluid (image modal)
- Fixed in Code Base
- 28 Oct 2016
- Medium
- Build: staging
- # 11995
- Diff
- ciar4n:well-grid-imageform
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
2 column grid in the media modal appearing in single column
Summary of Changes
Bootstrap 2.3 does not support a grid within a well using 'row'. Changed to 'row-fluid'.
Testing Instructions
Navigate to article editor and add image
Edit: Issue found running Windows in Firefox and Chrome however not in IE.
Before
After
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Media Manager Administration Components |
| Title |
|
||||||
@brianteeman thank you for checking. Running Windows. Issue present in Firefox and Chrome however not in IE. Reference on the issue of a grid inside a well... twbs/bootstrap#1446 (comment)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11995.
I have tested this item
I reproduced the issue with IE 11. The PR solves it.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11995.
I have tested this item
i have tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11995.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11995.
| Status | Pending | ⇒ | Ready to Commit |
weird its only an issue on windows but i can confirm it and have now set this to rtc - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11995.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-28 19:18:18 |
| Closed_By | ⇒ | zero-24 |
Merged. Thanks!
| Labels |
Removed:
?
|
||
I can NOT replicate this issue before applying the PR
On 9 September 2016 at 07:43, Ciaran Walsh notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/