[#11977] - Correct languages/package extensions name in install sql files
- Closed
- 17 Sep 2016
- Medium
- Build: staging
- # 11977
- Diff
- andrepereiradasilva:correct-values
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: 1 infograf768 Unsuccessful: 0
Summary of Changes
Ths simple PR is just to correct an inconsistency in what is installed and the names of the languages/package that are in the joomal sql files.
What is installed is this:
So the install sqls should have that.
Testing Instructions
Code review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation SQL Postgresql MS SQL |
| Labels |
Added:
?
|
||
I don't care myself -
Maybe @infograf768 has an opinion
@brianteeman that is just the install files that are not consistent.
Try to install a new staging and check what are the extension names for those extensions after install.
Also i think the iso codes you are referring are the ones that identify the language and the country
- Language: ISO 639 1 https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes
- Country: ISO 3166-1 alpha 2 https://en.wikipedia.org/wiki/ISO_3166-1#Officially_assigned_code_elements
For language that don't have a ISO 639 1 code i don't know with code is uses (Dari Persian for instance uses prs in Joomla)
Update i saw now where prs comes from http://www-01.sil.org/iso639-3/documentation.asp?id=prs, ie, ISO 639-3
This should be correlated with:
https://github.com/joomla/joomla-cms/blob/staging/language/en-GB/install.xml#L3 AND
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/install.xml#L3
name value (IMO).
But there are those files:
https://github.com/joomla/joomla-cms/blob/staging/language/en-GB/en-GB.xml#L3 AND
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.xml#L3
name show ISO names...
Actually have been saying that for some time ...
Imho, there is no reason to use "United Kingdom" as en-GB is enough in the install.xml(s) and en-GB.xml(s)
[btw, I just released a new version of com_localise which changes the install.xml name to the same name as the xx-XX.xml and not to the language pack name of the type <name>French Language pack</name> (for French) to differentiate languages and pack in the Manager.]
It is OK though, as I see it, to use "United Kingdom" in the Installation xml files in metadata <name.
| Labels |
Added:
?
|
||
| Category | Installation SQL Postgresql MS SQL | ⇒ | Language & Strings Administration Installation SQL Postgresql MS SQL |
ok changed in install.xml files too.
BTW, @infograf768 should it be "Language Pack" or "Language Package"? We normally use the term "Package", IIRC this is the only place where "Pack" is used.
also for admin install.xml file i guess.
as for pack or package, not really important imho as long as it is different from install.xml
also for admin install.xml file i guess.
i already changed that one.
as for pack or package, not really important imho as long as it is different from install.xml
it's different, just asking because we use "Package" elsewhere in Joomla, but ok, will leave "Pack".
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11977.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-17 11:36:26 |
| Closed_By | ⇒ | andrepereiradasilva |
I'm not sure about this. I dont remember the links right now but there were ISO standards that were used for the naming.