Feeling Lucky
?
?
[#11966] - [unit tests] Just need to check one microsecond now (3.7.x Branch)
- Fixed in Code Base
- 7 Sep 2016
- Medium
- Build: 3.7.x
- # 11966
- Diff
- andrepereiradasilva:patch-5
- Failure continuous-integration/drone the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: 0 Unsuccessful: 0
Summary of Changes
Since 417a6a6 (merged in the 3.7.x branch) JDate('now') return the current date with microseconds in the 3.7.x. branch there is no need to wait for 1 second.
So this PR makes JDate('now') tests wait just one microsecond (is enough to get different dates), instead of a whole second, and with that gaining 2 extra second of performance in every unit tests.
Testing Instructions
Unit tests pass.
Very simple code review.
Documentation Changes Required
None.
The description was changed
joomla-cms-bot
-
The description was changed
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Unit Tests |
The description was changed
wilsonge
- | Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-07 11:30:05 |
| Closed_By | ⇒ | wilsonge |
andrepereiradasilva
- comment
- 7 Sep 2016
thanks
Note the tests that didn't pass are drone tests not related to this.
You can check here all unit tests passed on travis https://travis-ci.org/joomla/joomla-cms/builds/158140401