[#11944] - Introtext Show/Hide parameter is ignored in Blogview / Fix
- Fixed in Code Base
- 6 Sep 2016
- Medium
- Build: staging
- # 11944
- Diff
- designbengel:fix_introtext_showhide_blogview
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR adds a simple if clause to check if the introtext is set to show or hide in the Parameters
Testing Instructions
Before Applying the patch:
In your Joomla! Test environment navigate to the subpage /article-category-blog
Setup the Menuitem in Backend to hide introtext there
Check the Frontend, The introtext still shows up.
After Applying the patch:
1) Setup the Menuitem in Backend to hide introtext in "article category blog".
The introtext should be hidden now.
2) Setup the Menuitem to show introtext in "article category blog".
The introtext should be shown.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components |
- I have tested successfully.
-
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11944.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11944.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11944.
I wouldn't put the plugin within the if, it should be before
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 06:52:59 |
| Closed_By | ⇒ | rdeutz |
I dont think this is correct. I will double check soon
On 6 September 2016 at 07:52, Robert Deutz notifications@github.com wrote:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11944 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPH8dMTF5BKEG7HY8PxBbQezx4J0ehVks5qnQ3LgaJpZM4J1W6X
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
This needs to be reverted as it is incorrect and is a b/c break
This is the scenario the feature exists for,
Create a movie site with articles about each movie
The intro text displayed on the blog page is a summary of the movie
The full article is a complete review of the movie
So when Hide introtext is used
The blog view shows the summary of the movies
The article view shows the complete review minus the summary
Missed that, going to revert this one, but we might need to change the label so that it is more clear what this setting is for and we might move the setting to a different place. It is misleading when it is between "Linked Titles" and "Position of Article Info", these setting are for the blog view itself.
I checked this and can´t confirm:
If i set introtext to hide it doesn´t affect the article setting.
With the fix it still respects the options inside the article?
@designbengel it might be that this is not working correct, but the description @brianteeman made is correct, the tooltip say the same. So if it is not working then we need to fix the bug instead of changing the functionality :-)
Ok, true about the tooltip, i´ll have a look at this, thx!
@brianteeman can you confirm the option has no influence on the Article view, when Article is set to show/hide the introtext itself?
An article option will always override the menu option
@brianteeman that absolutely makes no sense for me then giving the option "Use Article settings" there?
I have tested this item✅ successfully on 5a6911d
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11944.