the best way to do it is to simply edit the less file and then from a
command line go to the build folder and type php generatecss.php

On 5 September 2016 at 15:26, designbengel notifications@github.com wrote:

Close Button on iOs doesn´t work

Bug in Bootstrap: Alerts are not closeable on iOs
Summary of Changes

Added cursor:pointer; to alerts.less and bootstrap_rtl.less to have the
altert message be close-able on iOs too.
Testing Instructions

Please test on iOs (not Chrome emulation or something else)
Before applying the patch:
Type in wrong login credentials using Joomla! Protostar Template.
Try to dismiss the alert by tapping on the close button.

• Nothing will happen

After applying the patch:
Login again with wrong credentials
Try to dismiss the altert
Alert should close now.
Documentation Changes Required

Sorry i deleted template.css completely and compiled over Template
Manager, any better way to do that? Thanks!

[image: image]

https://cloud.githubusercontent.com/assets/828371/18250769/73c28c52-7385-11e6-8bb4-b2a4a394f5a7.png

You can view, comment on, or merge this pull request online at:

#11939
Commit Summary

• Add cursor:pointer; to alert to make the close icon working on iOs

File Changes

• M media/jui/less/alerts.less https://github.com/joomla/joomla-cms/pull/11939/files#diff-0 (1)
• M media/jui/less/bootstrap-rtl.less https://github.com/joomla/joomla-cms/pull/11939/files#diff-1 (1)
• D templates/protostar/css/template.css https://github.com/joomla/joomla-cms/pull/11939/files#diff-2 (7662)
• M templates/protostar/less/template.less https://github.com/joomla/joomla-cms/pull/11939/files#diff-3 (2)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/11939.patch
• https://github.com/joomla/joomla-cms/pull/11939.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11939, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UlEs0aIYhr2l_4m1sDTo8jRPcUMks5qnCaugaJpZM4J1HlO
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Thank you Brian! Done :)

You've forgotten to compile the template.css from Protostar

I have tested this item ? unsuccessfully on 6a75e03

- I have tested unsuccessfully on iPhone5c device.

• close button isn't working.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11939.}

Thank you @bhavikTailored - Sorry, went a bit lost by reverting everything - now it should work, can you check please?

Nope thats not correct you have 402 changed files ;)

Maybe i´ll just create a fresh new PR :-D

let me know if you get stuck or want me to do it

On 6 September 2016 at 22:02, designbengel notifications@github.com wrote:

Maybe i´ll just create a fresh new PR :-D

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11939 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8airpX5Pkl8la94yGiVJ8irTwcviks5qndTbgaJpZM4J1HlO
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Thank you Brian, i just made mistakes by reverting changes and was lost in Pull/Push :-D
New one is here: #11965