[#11920] - [category item modal field] Apply on more fields for categories (3.7.x branch)
- Closed
- 11 Sep 2016
- Medium
- Build: 3.7.x
- # 11920
- Diff
- andrepereiradasilva:new-category-3.7branch
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This is the last PR (i hope) of this sequence.
Thsi is only adds the button in the xmls of fields that in 3.7.x branch use now the category modal and it's a sequence of #11857.
Testing Instructions
- Use joomla latest 3.7.x branch
- Apply this patch
- Test the new modal buttons behaviour in:
- "Category List" Menu item type,
- "Category Blog" Menu item type,
- "List Contacts in a Category" Menu item type
- "List News Feeds in a Category" Menu item type,
- New/Edit "User Note", "Category" field
- New/Edit "Articles - Categories" Module, "Category" field
- Test the "Edit", "Create", "Select" and "Clear" buttons
- Code review to check all is ok.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Front End Modules |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
@bhavikTailored how did you get the 3 buttons, is not supposed to be like that.
Did you used this patch in 3.7.x branch as said in this PR description?
Sorry @andrepereiradasilva.
Currently, I am using latest staging Joomla(3.6.3-dev) then apply this patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
so that's not a valid test. you have to use 3.7.x branch for testing this
Hello @andrepereiradasilva ,
Can you give me detail how use joomla latest 3.7.x branch?
- So I will do test again.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
in linux i use
git clone --depth 1 -b 3.7.x https://github.com/joomla/joomla-cms /path/to/joomla-370Then install as usual.
Thanks @andrepereiradasilva,
- I have installed Joomla! 3.7.0-dev as per given command.
- It's working for me so I have tested successfully.
-
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
I have tested this item
Unsuccessful.
The fields concerned should keep required="true" when present as otherwise one can save an item with no category chosen.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
Ups. Remover by mistake. Will correct
added the required again
I noticed the com_users notes category select doesn't have a required, is this a mistake, or is supposed to work like this?
It was forgotten indeed.
Who knows with user_notes - its a mystery
It does work without a category though
On 6 September 2016 at 10:36, andrepereiradasilva notifications@github.com
wrote:
added the required again
I noticed the com_users notes category select doesn't have a required, is
this a mistake, or is supposed to work like this?—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11920 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bpEwlkmmsqOySM1rbIxS0Ai5ZNGks5qnTQYgaJpZM4J0jIo
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
i will make a PR to correct that
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
We need another tester here. Thanks.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
| Status | Pending | ⇒ | Ready to Commit |
rtc. thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-11 13:40:00 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11920.