[#11916] - [menu item modal field] Adds Create Menu Item button and other improvements (3.7.x branch)
- Fixed in Code Base
- 2 Oct 2016
- Medium
- Build: 3.7.x
- # 11916
- Diff
- andrepereiradasilva:new-menu
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR is the sequence of #11830 but for now for menus modal in 3.7.x branch .
For list of changes see #11830 (same changes, but for menus in 3.7.x branch now).
Similiar PR:
Animated Gif (click to view in full screen)
Testing Instructions
- Use joomla latest 3.7.x branch
- Apply this patch
- Create a Menu item Alias Type
- Test all the "Edit", "Create", "Select" and "Clear" buttons (as animated gif)
- In a multilanguage install edit a menu and try the modal button in the associations tab
- Test all the "Edit", "Create", "Select" and "Clear" buttons.
- Code review to check all is ok.
Note: there are more sites when this modal change is apllied (see code diff), you could test them too: mod_login, mod_menu, logout menu item, login menu item
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings Front End Modules |
| Labels |
Added:
?
?
|
||
jeckodevelopment
- | Labels |
Added:
?
|
||
Works OK. Test successful.
Note for another PR if possible
I remarked an issue which is also present in all similar modals:
When selecting an item from the Associations tab, the association column is not displayed in the modal. One could involuntarily break some existing associations by choosing an item already associated.
Here is a POC for articles (associations column not set to hidden-phone):
In this POC, as I use <?php echo JHtml::_('contentadministrator.association', $item->id); ?>
which evidently also adds the link. We do not want that, only the buttons.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11916.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11916.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
@andrepereiradasilva could you have a look at the travis problem, thanks!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-02 18:26:34 |
| Closed_By | ⇒ | rdeutz |
@andrepereiradasilva
Found an issue. Please look at:
https://issues.joomla.org/tracker/joomla-cms/12277
| Labels |
Removed:
?
|
||
The Travis errors are due to other issue not related to this PR in the 3.7 brannch só is ready for test. @infograf768 can you test ?