? Failure

User tests: Successful: Unsuccessful:

avatar t-arapi
t-arapi
3 Sep 2016

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Documentation Changes Required

avatar t-arapi t-arapi - open - 3 Sep 2016
avatar t-arapi t-arapi - change - 3 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2016
Category Administration Components
avatar brianteeman brianteeman - change - 3 Sep 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 3 Sep 2016

Please describe the problem this pr fixes. How to replicate the bug and how to test the fix

avatar t-arapi
t-arapi - comment - 3 Sep 2016

When you order all the items, there's no problem, but when i try to put a different pagination order (like for example when i try o put another order, 5 or 10 for pagination, the 1st page is correct, but the other ones are not accurate, as they change the order without me knowing, like they go randomly)
This is a file that shows what I mean:
aaaa

avatar brianteeman
brianteeman - comment - 3 Sep 2016

Sorry that shows nothing

avatar t-arapi
t-arapi - comment - 3 Sep 2016

Category list:

total

First page 5 items:

p1

Second page:

p2

avatar brianteeman
brianteeman - comment - 4 Sep 2016

Sorry but I still cannot see what is wrong


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

avatar jeckodevelopment
jeckodevelopment - comment - 4 Sep 2016

@t-arapi can you please create an animation that shows the issue? because screenshots are not so clear

avatar t-arapi
t-arapi - comment - 4 Sep 2016
  1. Create 7 categories
  2. Show content categories diplay all
  3. Reorder all cats (remember the order)
  4. Show content categories limit 5 (pagination has 2 pages)
  5. Go to page 2 and order up the last item
  6. Show content categories diplay all
  7. Check up the order that you have now and if it is the same as the previous one

Does this help somehow?

avatar brianteeman
brianteeman - comment - 4 Sep 2016

I think I have replicated it - is this what you meant

cats

avatar t-arapi
t-arapi - comment - 4 Sep 2016

Yes, more or less, although the category number 9 should be the sixth in the final order and not the fisrt.

avatar brianteeman
brianteeman - comment - 4 Sep 2016

Yes that's the bug?

On 4 Sep 2016 3:34 p.m., "t-arapi" notifications@github.com wrote:

Yes, more or less, although the category number 9 should be the sixth in
the final order and not the fisrt.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11906 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZI0dPYlGTUJPNT5TYJgxbT-c7Mpks5qmtcFgaJpZM4J0Rlm
.

avatar brianteeman brianteeman - test_item - 4 Sep 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 4 Sep 2016

I have tested this item successfully on 508b3f4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

avatar brianteeman brianteeman - change - 4 Sep 2016
Labels Removed: ?
avatar AnishaTailored AnishaTailored - test_item - 6 Sep 2016 - Tested successfully
avatar AnishaTailored
AnishaTailored - comment - 6 Sep 2016

I have tested this item successfully on d6b66a5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

avatar truptikagathara truptikagathara - test_item - 6 Sep 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 6 Sep 2016

I have tested this item successfully on d6b66a5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

avatar brianteeman brianteeman - change - 6 Sep 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 6 Sep 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 6 Sep 2016
Milestone Added:
avatar rdeutz
rdeutz - comment - 6 Sep 2016

This needs more testing, I am not 100% sure that the fix is ok and doesn't have side effects.

avatar rdeutz rdeutz - assigned - 6 Sep 16
avatar rdeutz rdeutz - change - 6 Sep 2016
Status Ready to Commit Needs Review
Labels
avatar rdeutz
rdeutz - comment - 6 Sep 2016

set to needs review since we have tested this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2016
Labels Removed: ?
avatar tomartailored tomartailored - test_item - 6 Sep 2016 - Tested successfully
avatar tomartailored
tomartailored - comment - 6 Sep 2016

I have tested this item successfully on d6b66a5

yes , i have tested this successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

avatar brianteeman brianteeman - change - 6 Sep 2016
Milestone Removed:
avatar brianteeman
brianteeman - comment - 6 Sep 2016

Removed the milestone for now

avatar brianteeman
brianteeman - comment - 6 Dec 2016

@rdeutz have you done a review?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906.

avatar roland-d
roland-d - comment - 13 May 2017

nudging @rdeutz

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 May 2017
The description was changed
Status Needs Review Information Required
avatar joomla-cms-bot joomla-cms-bot - edited - 14 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2017
Category Administration Components Administration com_categories Components
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jun 2017

maybe @rdeutz is enough.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Aug 2017

If this PR get no Response, it will be closed at 17th September 2017.

avatar brianteeman
brianteeman - comment - 18 Aug 2017

@franz-wohlkoenig this PR is waiting a review from a maintainer. It has been tested by several people as good but @rdeutz wanted to hold back on merging it so he could do further tests. It shouldnt be closed just because a maintainer hasnt approved/merged it

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Aug 2017

thanks for Info @brianteeman and thanks for approve @rdeutz

avatar rdeutz rdeutz - change - 18 Aug 2017
Status Information Required Ready to Commit
avatar rdeutz
rdeutz - comment - 18 Aug 2017

just go ahead with this, @mbabker can make the decision


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906.

avatar mbabker mbabker - change - 18 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-18 14:04:50
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Aug 2017
avatar mbabker mbabker - merge - 18 Aug 2017
avatar brianteeman
brianteeman - comment - 18 Aug 2017

Thanks

Add a Comment

Login with GitHub to post a comment