[#11900] - [tests] Remove cacheTest -> isBlacklisted() method at all
- Fixed in Code Base
- 6 Sep 2016
- Medium
- Build: staging
- # 11900
- Diff
- csthomas:jenkins_blacklist
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11821.
Summary of Changes
Jenkins errors fix for memcache(-d)
Testing Instructions
Jenkins and Travis plus code review.
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
Redis is not set up on that server.
Then I will remove Redis from blacklist.
Any other thought about that PR?
| Title |
|
||||||
I would prefer to have separate env variables and not something based on jenkins as a build env
memcache=yes
memcached=no
....
ok, then I remove all blacklist stuff.
| Title |
|
||||||
So memcached is running on jenkins, but still makes sense to make it configurable
| Title |
|
||||||
@rdeutz I added that functionality, you can test like:
[UPDATED] - use uppercase
$ FILE=0 MEMCACHE=0 APCU=NO REDIS=0 CACHELITE=no MEMCACHED=0 php libraries/vendor/phpunit/phpunit/phpunit tests/unit/suites/libraries/joomla/cache/storage
PHPUnit 4.8.27 by Sebastian Bergmann and contributors.
Warning: The Xdebug extension is not loaded
No code coverage will be generated.SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Time: 107 ms, Memory: 8.00MB
OK, but incomplete, skipped, or risky tests!
Tests: 63, Assertions: 0, Skipped: 63.
For my laptop getenv() works but $_ENV not.
What about other servers?
For now memcached storage is not full tested.
Take a look in code coverage at
https://developer.joomla.org/cms-coverage/libraries/joomla/cache/storage/index.html
Memcache storage is ok.
Memcached is not full tested because of old blacklists.
Is something missing in that PR?
What about syntax?
| Title |
|
||||||
Then we can remove it at all.
I have changed code and remove only all isBlacklisted() stuff.
Travis is happy:)
Jenkins should be too.
From now code coverage will be generated for memcached storage.
If it works go with it.
On Tuesday, September 6, 2016, Robert Deutz notifications@github.com
wrote:
Any objections @mbabker https://github.com/mbabker @wilsonge
https://github.com/wilsonge ?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11900 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoYjK5aZ7b82l8il_d9g2R1jXF1JFks5qnYwagaJpZM4J0IA-
.
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 16:39:52 |
| Closed_By | ⇒ | rdeutz |
Should Redis be blacklisted or not?
I do not blacklist it on JCacheTest and JCacheStorageTest. (because probably it failed without exception)
What extensions are loaded on php on Jenkins? (memcache: yes, memcached: yes, redis: ??)