[#11895] - [fix] When installing Joomla! and mail sending fails you are not getting to the next screen.
- Fixed in Code Base
- 31 Oct 2016
- Medium
- Build: staging
- # 11895
- Diff
- zero-24:install_mail
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11891 .
Summary of Changes
The libraries/legacy tree isn't being included in the install app because its code was rewritten to not be dependent on it. Most likely this has been an issue since the PR that removed the "if JError exists use it for error handling else throw an Exception" logic from JMail. The error handling is trying to call a non-existing class.
Change installation/application/framework.php to require import.legacy.php instead of import.php.
Thanks @mbabker #11891 (comment)
Testing Instructions
- Download this branch: https://github.com/zero-24/joomla-cms/archive/install_mail.zip
- upload it to the server
- add
$return = false;here: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/mail/mail.php#L133 - try to install joomla on the pre final step make sure you enable mail sending of the configuration. ##### Expected result
Installation succes should be independant of the setting send Email Configuration option.
Actual result
No matter which of the install-options you choose you will be getting this same Finalisation-screen until you set the send Email Configurations to No.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 11891 |
| Relation Type | ⇒ | Pull Request for |
However, when looking at the changed files in the PR, I think that either the test instructions are not well written or I didn't get it.
I will test another time (with mail function disabled and changed files.
Well, I have no idea how this fits in this PR testing infrastructure.
However, when making proposed changed in installation/application/framework.php and installation/controller/install/email.php and not adding $return = false; to libraries/joomla/mail/mail.php on line 133 , also making sure that the mail-function is disabled on the server, then it works as expected.
So a succes I would say.
Yes sorry for the confusing ;) you need to install this branch (with the changed file). The $return = false just make sure you got the error you can also disable the mail function.
I can rewrite the testinstructions if im back to me PC ;)
I have tested this item
Now works as expected.
In case the mail cannot be sent, no warning is shown. I think it's always been that way even though a warning in the backend would be nice.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11895.
In case the mail cannot be sent, no warning is shown. I think it's always been that way even though a warning in the backend would be nice.
I'm not sure i understand you? There is a button to test mail sending in the backend?
There's no message saying the mail failed to send if JMail returns a
Boolean value because the JError default handling ignores errors and it's
not throwing an Exception to trigger the catch block in the code sending
the mail. So you'd need an extra check if the result of JMail::Send() !==
true.
On Saturday, September 3, 2016, zero-24 notifications@github.com wrote:
In case the mail cannot be sent, no warning is shown. I think it's always
been that way even though a warning in the backend would be nice.I'm not sure i understand you? There is a button to test mail sending in
the backend?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11895 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoY8dSm6RtN6-yQarqeLCmPIJOhznks5qmcdwgaJpZM4Jz7Lx
.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
brianteeman
- | Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
If you don't want to fack the code you can also try to install: https://github.com/zero-24/joomla-cms/archive/install_mail.zip without any changes. If that works we are good to go here as we have another successful test for the other aspect allready. Thanks!
Would be great to get a seccond test here
I have tested this item
1. Used latest staging and applied patch with patchtester
2. Deleted configuration.php
3. Added $return = false; here: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/mail/mail.php#L133
4. tried to install joomla on the pre final step make sure you enable mail sending of the configuration.
Installation went fine. So, works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11895.
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Pending |
RTC cc @rdeutz
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11895.
Thanks @andrepereiradasilva and @slibbe
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-31 16:14:59 |
| Closed_By | ⇒ | rdeutz |
I have tested this item? unsuccessfully on f7801b0
With the proposed "add $return = false;" in line 133 of libraries/joomla/mail/mail.php and having set send Email Configuration to yes, the only way to get past the Finalisation screen is turning on the mail-function on the server.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11895.