[#11892] - Reduce use of JFactory::getConfig() where practical
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 11892
- Diff
- mbabker:config-refs
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The data loaded from JFactory::getConfig() is already injected into the application object, so in places where we are already referencing the application object, we can skip referencing data out of another object. We can also save a little memory and not put a reference to the object in memory when only using it once.
We also have a JDEBUG constant which defines if the application is globally set to debug mode, use that as practical over referencing the configuration data.
Testing Instructions
The correct configuration values continue to be referenced in the changed locations.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Libraries Plugins Front End Unit Tests |
I have tested this item
code review and also applied patch navigated a little in frontend and backend and didn't find issues.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11892.
| Status | Pending | ⇒ | Ready to Commit |
RTC. based on the tests above.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11892.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 11:07:45 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 564b5e5
Based on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11892.