? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
1 Sep 2016

A potential restyling of the Media Manager.

Summary of Changes

Only Isis template.css is effected. Increased size of image preview with minimal increase in thumbnail footprint. Centered display of thumbnails across all image ratios and orientation.

Testing Instructions

Install the patch and browse to Media Manager. Full refresh probably needed after applying patch. For the moment does not effect any modals, only Content->Media

Before Patch
media-before

After Patch
media-after

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 1 Sep 2016
avatar ciar4n ciar4n - change - 1 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2016
Category Templates (admin) Administration
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2016
Labels Added: ?
avatar ciar4n ciar4n - change - 1 Sep 2016
The description was changed
avatar ciar4n ciar4n - edited - 1 Sep 2016
avatar C-Lodder
C-Lodder - comment - 1 Sep 2016

Nice. Out of all honesty though, It would be great to simplify the media manager so that it removes the need for a checkbox AND delete button for each image.

Something like this, so the page dedicates all space to the image and all focus goes on them. Just my opinion:

screenshot

avatar bhavikTailored
bhavikTailored - comment - 1 Sep 2016
avatar bhavikTailored bhavikTailored - test_item - 1 Sep 2016 - Tested successfully
avatar bhavikTailored
bhavikTailored - comment - 1 Sep 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11874.

avatar ciar4n
ciar4n - comment - 1 Sep 2016

@C-Lodder I agree. The single click delete button is unnecessary and unforgiven. Probably best to keep a preview option in there. I considered what you suggest via CSS however it meant editing the com_media view to append the checkbox with a label. Seems easily achievable however my PHP knowledge is very limited so I took the safer route and opted against.

avatar ciar4n
ciar4n - comment - 1 Sep 2016

@brianteeman Thank you... I missed that. Testing throws me an error (Fatal error: Call to undefined function finfo_open) but I'm guessing it supersedes anything I'm doing here. Closing.

avatar ciar4n ciar4n - change - 1 Sep 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-09-01 11:57:29
Closed_By ciar4n
avatar ciar4n ciar4n - close - 1 Sep 2016
avatar ciar4n ciar4n - close - 1 Sep 2016
avatar brianteeman
brianteeman - comment - 1 Sep 2016

I would definitely submit your changes to that repo!!

On 1 September 2016 at 12:57, Ciaran Walsh notifications@github.com wrote:

Closed #11874 #11874.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11874 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b_N1kTxoLxZ-MG3QN7OSJx1FmxJks5qlr2qgaJpZM4JyiEw
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar ciar4n
ciar4n - comment - 29 Oct 2016

@brianteeman Just wondering if the improved media manager doesn't make it for 3.7, should I re-open this PR (or a version of it)?

avatar brianteeman
brianteeman - comment - 29 Oct 2016

Best to ask @rdeutz and @wilsonge

avatar rdeutz
rdeutz - comment - 29 Oct 2016

@ciar4n yes please reopen it, any improvement makes sense. I don't see a new media manager ready for 3.7 so far

avatar ciar4n
ciar4n - comment - 29 Oct 2016

@rdeutz Done :-)

@C-Lodder I should get a chance to try your suggestion over the next days for which I'll create a new PR.

avatar ciar4n ciar4n - change - 29 Oct 2016
Status Closed New
Closed_Date 2016-09-01 11:57:27
Closed_By ciar4n
avatar ciar4n ciar4n - reopen - 29 Oct 2016
avatar ciar4n ciar4n - reopen - 29 Oct 2016
avatar C-Lodder
C-Lodder - comment - 29 Oct 2016

sounds good

avatar brianteeman brianteeman - test_item - 30 Oct 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 30 Oct 2016

I have tested this item successfully on 0a979ea

It does what it says and from a usability perspective I prefer it to #12643


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11874.

avatar ciar4n
ciar4n - comment - 1 Nov 2016

Closing in favor of #12643

avatar ciar4n ciar4n - change - 1 Nov 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-11-01 09:19:28
Closed_By ciar4n
avatar ciar4n ciar4n - close - 1 Nov 2016
avatar ciar4n ciar4n - close - 1 Nov 2016
avatar C-Lodder
C-Lodder - comment - 1 Nov 2016

Wrong link ;) #12643

Add a Comment

Login with GitHub to post a comment