[#11872] - Fix unittest on cache - 5 seconds less
- Fixed in Code Base
- 13 Dec 2016
- Medium
- Build: staging
- # 11872
- Diff
- csthomas:test-gc-fix
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Currently JCacheTest->testGc() method work with cache disabled, without configured storage, but take 5 seconds.
Changes:
- enable caching
- set storage to file
- remove
sleep(5)and useTestReflectionto change modification time of cached file. - After garbage collection:
- add test for file exists before check cache data. File storage deletes expired file on
getmethod so we have to check file exists beforegetto be sure thatgcworks as expected. - add additional test for non expired data
- add test for file exists before check cache data. File storage deletes expired file on
Testing Instructions
Travis passed.
Require code review.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Labels |
Added:
?
?
|
||
@csthomas i prefer my https://github.com/csthomas/joomla-cms/pull/3/files because it makes sure we only delete expired cache.
May be you have rights that on JCacheTest we should not use low level var like handler->_now
Did not understood
Sorry I say about something else.
I agree with you that some value should stay after gc.
ok will wait for the changes them.
Latest staging (your other patch already merged)
Before Patch:
Time: 5.38 seconds, Memory: 10.00MB
After Patch:
Time: 835 ms, Memory: 10.00MB
So almost 5 seconds less in all unit tests.
I have tested this item
as comments above
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11872.
wow just check a php 7 travis build and the unit test runned in 20 sec, even without this PR that will decrease that time in more 5 sec
https://travis-ci.org/joomla/joomla-cms/jobs/157294479#L1248
can we have another test or review here so we can make all unit tests 5 seconds faster?
| Title |
|
||||||
| Title |
|
||||||
This PR is only for unittest speed up - 5 seconds less.
Is no one is interested?
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Removed:
?
|
||
I have tested this item
Looks good, by code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11872.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11872.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-13 12:13:40 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
cpfeifer
-
see csthomas#3 for futher improvements