? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
31 Aug 2016

Summary of Changes

Add missing flags.
Language Packs:

  • German AT (de-AT)
  • German LI (de-LI)
  • German LU (de-LU)
  • German CH (de-CH)
  • Sinhala (si-LK)

Testing Instructions

Check this images and language packs.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 31 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 31 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 31 Aug 2016
Title
Add missing flags
Add missing language flags
avatar andrepereiradasilva andrepereiradasilva - edited - 31 Aug 2016
avatar Bakual
Bakual - comment - 1 Sep 2016

In Switzerland (de-CH) we usually don't use the Swiss flag to indicate the language. That is because Switzerland has four official languages and thus the flag wouldn't tell you which language it should represent. We usually use the flag from Germany, France and Italy to indicate the languages (the fourth language Romansh is ignored).
Also the flag would have to be a square and not rectangle ?

So imho at least the Switzerland flag doesn't make any sense to be included. Can't say anything about the other ones.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Sep 2016

Aldo the ch flag used was the one already in joomla

avatar Bakual
Bakual - comment - 1 Sep 2016

For each German language pack we should use the de_de.gif, with a different name
de_at.gif, de_li.gif, etc

I'd say for de-AT, the Austrian flag would be appropriate as they only have german as official language. But I don't know what tehy usually use there.

avatar Bakual
Bakual - comment - 1 Sep 2016

Aldo the ch flag used was the one already in joomla

Yep, technicalls it is a wrong one. But it depends how much one cares :)
Switzerland is one of the very few countries with a square flag.

avatar infograf768
infograf768 - comment - 1 Sep 2016

The only issue we have with using the same flag for different languages is the impossibility to differentiate them (specially in back-end as in frontend one may decide to use the language tag or name instead of the flags.)

avatar infograf768
infograf768 - comment - 1 Sep 2016

After more thought, I think this PR is OK.
ch.gif was added to core to let it used if desired and if someone wants to change the content language flags, he can. Therefore using de-DE flag for de-CH, etc.
This is the only solution to have different flags per default for each content language.

avatar infograf768 infograf768 - test_item - 1 Sep 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Sep 2016

I have tested this item successfully on 1d0f4b7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11868.

avatar Bakual
Bakual - comment - 1 Sep 2016

This is the only solution to have different flags per default for each content language.

Currently, it would work because there is no official pack for fr-CH and it-CH. But if someone decides to add those (which for consistency with de-CH should be done) you have de-CH, fr-CH and it-CH all using the Swiss flag by default? Can't be right.
Keep in mind that the de-CH language pack is actually de-DE just with a different language code. It's by no means a Swiss German pack.

avatar infograf768
infograf768 - comment - 1 Sep 2016

hmm, maybe this then
de_ch

avatar AnishaTailored AnishaTailored - test_item - 1 Sep 2016 - Tested successfully
avatar AnishaTailored
AnishaTailored - comment - 1 Sep 2016

I have tested this item successfully on 1d0f4b7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11868.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Sep 2016

@Bakual i tottaly understand you, that's exactly why flags should not represent languages.
But this is the way Joomla works and allows the user to costumize if they want or don't even show the languages flags in the frontend if they don't want (language swithcer in select list mode).

However is not the intent of this PR to change how Joomla represents content languages.
This PR only intends to correct a bug that when installaing a multilanguage install with those languages the flags for those language packs are missing, thus generating a image not found error.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Sep 2016

hmm, maybe this then
45577f3a-7033-11e6-8aeb-34816134ba89

@Bakual do you agree with this?

avatar Bakual
Bakual - comment - 1 Sep 2016

I'd prefer something like this:
ch-de (stolen from internet as my graphics skills suck)
I saw that a few times being used.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Sep 2016

@Bakual thanks. please do a PR to this branch or make a new PR with your proposal.

avatar Bakual
Bakual - comment - 1 Sep 2016

As said my graphic skills aren't good enough to do the image and we can't just steal it from another site for obvious reasons.

avatar infograf768
infograf768 - comment - 1 Sep 2016

another one:
de_ch

avatar infograf768
infograf768 - comment - 1 Sep 2016
avatar MATsxm
MATsxm - comment - 1 Sep 2016

If this can help
http://forum.tsgk.com/viewtopic.php?t=4921

You can see for:
Swiss States and Territories
and German States and Territories

avatar Bakual
Bakual - comment - 1 Sep 2016

The one from the Wiki looks good to me.

avatar MATsxm
MATsxm - comment - 1 Sep 2016

that means you would use
3cde56181d1a5d9698738e95ec5582ea
for en-US ?

avatar Bakual
Bakual - comment - 1 Sep 2016

I don't know about US but from my understanding the official language in the USA is only english. So the american flag would work there.
Canada would be another example similar to Switzerland because there are two official languages (French and English). But I don't know how "language flags" are handled there.

avatar MATsxm
MATsxm - comment - 1 Sep 2016

Nope.
it is like Swiss ?
as you have a "french" canadian fr-CA with the canadian flag and then the "french" Québecois (much more restrictive because of their Law 101) with the Flag of Québec

avatar brianteeman
brianteeman - comment - 1 Sep 2016

Legally the USA does not have an official language :)

avatar MATsxm
MATsxm - comment - 1 Sep 2016

Disagree as some (Acadians for example or part of the region of Nouveau-Brunswick) are speaking also french but are not part of Québec - the flag you are using here https://github.com/joomla/joomla-cms/blob/staging/media/mod_languages/images/fr_ca.gif - and the "french" spoken are not the same.
Free advice, never tell a "Quebecer" he speaks Acadian or even Canadian

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Sep 2016

(seems i opened pandora's box yet again ...)

avatar MATsxm
MATsxm - comment - 1 Sep 2016

Naaa, don't worry... we all know the end already ;)

avatar brianteeman
brianteeman - comment - 1 Sep 2016

Selecting a flag should be the responsibility of the TT. if they choose a
specific flag and a user doesn't like it they can change it. It should not
be the role of core to make a decision on the flag to use.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Sep 2016

ok, so please someone ask the creators of the following language packages for a 18x12 gif image for each of this language packs.

  • German AT (de-AT)
  • German LI (de-LI)
  • German LU (de-LU)
  • German CH (de-CH)

Can anyone do that?

avatar Bakual
Bakual - comment - 1 Sep 2016

Can anyone do that?

Pinging @sisko1990 as he is the creator of all those packs (imho, they are identical anyway).

avatar jsubri
jsubri - comment - 1 Sep 2016

If we apply the logic of the flags presented here, the de_ch.gif, fr_ch.gif and it_ch.gif should be identical but do not represent languages.
Swiss French speaks french, while the Swiss German are speaking "Schweizerdeutsch" while educated in Hochdeutsch (german) and Swiss Italian are speaking italian. From a Joomla translation packs perspective, Swiss German are using the DE pack, Swiss French are using the FR pack and the IT pack for the Swiss Italian. So the translation packs are respectively DE, FR and IT and no official xx-CH flags exists!

Now if the translation teams have a specific flag for ca-ES "Catalan" they should be free to display an alternative flag for that.

avatar zero-24 zero-24 - change - 1 Sep 2016
Category Multilanguage
avatar infograf768
infograf768 - comment - 2 Sep 2016

@jsubri
We DO need different "flags" for each content language to differentiate them in the UI, specially in back-end.
The other reason should be simple to understand: a user may decide to make a multilang site which targets various specific language-speaking regions/countries (German in this example), for example a e-commerce site where prices are in Euros for Germany and Swiss Francs in Switzerland, so he will use a content language for each region/countries.

avatar brianteeman
brianteeman - comment - 2 Sep 2016

We dont need flags to differentiate the languages in the UI if we stop
incorrectly using flags to differentiate languages in the admin

On 2 September 2016 at 07:17, infograf768 notifications@github.com wrote:

@jsubri https://github.com/jsubri
We DO need different "flags" for each content language to differentiate
them in the UI, specially in back-end.
The other reason should be simple to understand: a user may decide to make
a multilang site which targets various specific language-speaking
regions/countries (German in this example), for example a e-commerce site
where prices are in Euros for Germany and Swiss Francs in Switzerland, so
he will use a content language for each region/countries.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11868 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b4mP0YilPeDYkfnh4FpAUqsJo-0ks5ql7-CgaJpZM4JyKkf
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar jsubri
jsubri - comment - 2 Sep 2016

Yes, I understand the need of it.
Problem statement: the country flag alone may not represent the language content.

IMHO getting the creation of 3 flags that slightly distinguish the language for CH-DE, CH-FR and CH-IT such as chde would be a good indicator of the regional flavor(s).
This would resolve the ugly mixture of multiple country flags.

avatar tomartailored tomartailored - test_item - 2 Sep 2016 - Tested successfully
avatar tomartailored
tomartailored - comment - 2 Sep 2016

I have tested this item successfully on 1d0f4b7

i have tested this item succesfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11868.

avatar Bakual Bakual - change - 2 Sep 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-02 18:34:35
Closed_By Bakual
avatar Bakual Bakual - close - 2 Sep 2016
avatar Bakual Bakual - merge - 2 Sep 2016
avatar Bakual
Bakual - comment - 2 Sep 2016

Merged the PR and changed the Swiss German flag with an own commit (d114493)

Add a Comment

Login with GitHub to post a comment