[#11865] - Replace Help Popup for Help modal
- Closed
- 31 Aug 2016
- Medium
- Build: staging
- # 11865
- Diff
- andrepereiradasilva:help-modal
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
The title says it all Replace Help Popup for Help modal.
Testing Instructions
Apply patch and test the "Help" buttons in the backend views.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
The test is checking the HTML the button's echoing. Yay for flaky tests
Even better the test is manipulating global state and causes side effects.
I'm not in favour of this change. Having a separate window means that the help screens can be separately navigated side-by-side with the application. You can follow along with a set of instructions on the help screen without having to cancel the help and then having to re-open the help screen again for the next instruction.
Good point. I hadn't thought of that scenario. Definitely a valid reason
not to accept this pr
so, how about adding a open in new window button in the modal footer for those that want to use that navigated side-by-side with the application?
What's the point of adding this extra step
ok i just tried what @chrisdavenport said and i have to say that's in fact handy for people learning joomla.
so i will close this PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-31 18:28:15 |
| Closed_By | ⇒ | andrepereiradasilva |
hum ... it seems this failed a unit test ...