[#11862] - [newsfeed modal field] Adds Create News Feed button and other improvements
- Closed
- 4 Sep 2016
- Medium
- Build: staging
- # 11862
- Diff
- andrepereiradasilva:new-newsfeed
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR is the sequence of #11830 but for now for newsfeed modal.
For list of changes see #11830 (same changes, but for newsfeed now).
Similiar PR:
Animated Gif (click to view in full screen)
Testing Instructions
- Use latest staging
- Apply patch #11830 and then this patch
- Create a Menu item Single News Feed type
- Test all the "Edit", "Create", "Select" and "Clear" buttons (as animated gif)
- In a multilanguage install edit a news feed and try the modal button in the associations tab
- Test all the "Edit", "Create", "Select" and "Clear" buttons.
- Code review to check all is ok.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Front End |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
- I have tested this issue successfully.
- But we should require apply patch first of #11830 then I have success.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11862.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11862.
I have tested this item
If you click on create and open the modal and then change your mind its not possible to close the modal
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11862.
I have tested this item
Sorry - didnt see I needed to apply another PR first - works great
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11862.
Sorry - didnt see I needed to apply another PR first - works great
@brianteeman If you didn't apply the other pacth that is not a valid test!
@andrepereiradasilva which is why I retested and then marked it as successful ;)
ok
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11862.
| Status | Pending | ⇒ | Ready to Commit |
Thanks. RTC Commiter please double check that the other PR is merged before this one.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11862.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-04 00:25:46 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 85de2a9
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11862.