? Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
31 Aug 2016

Summary of Changes

Removed unconditional return statement from foreach loop

The method is supposed to remove all instances of element but it exits the loop on first iteration only. Looks like a quick copy-paste from removeField may have caused this.

Testing Instructions

Form XML form.xml:

<form>
    <fields name="group1">
        <field name="field1"/>
    </fields>
    <fieldset name="set1">
        <fields name="group1">
            <field name="field2"/>
        </fields>
    </fieldset>
</form>
$form = new JForm('Test');

$form->load('form.xml');
$form->removeGroup('group1');

print_r($form);

Expected:
This should remove all fields nodes with name group1

Actual:
Only the first group is removed before patch. After patch this should remove all as expected.

Documentation Changes Required

None

avatar izharaazmi izharaazmi - open - 31 Aug 2016
avatar izharaazmi izharaazmi - change - 31 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 31 Aug 2016
Labels Added: ?
avatar dgt41 dgt41 - test_item - 2 Sep 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 2 Sep 2016

I have tested this item successfully on 3ef9036


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11856.

avatar sonalitailored sonalitailored - test_item - 9 Sep 2016 - Tested successfully
avatar sonalitailored
sonalitailored - comment - 9 Sep 2016

I have tested this item successfully on 3ef9036


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11856.

avatar izharaazmi
izharaazmi - comment - 29 Sep 2016

We have 2 success, can it be moved forward please?

avatar zero-24 zero-24 - change - 29 Sep 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 29 Sep 2016

RTC Sorry it get missed anyhow.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11856.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Oct 2016

Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release

avatar rdeutz
rdeutz - comment - 18 Oct 2016

Needs an update of the @return tag

avatar izharaazmi
izharaazmi - comment - 19 Oct 2016

Is that ok @rdeutz ?

avatar rdeutz rdeutz - change - 25 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-25 17:40:04
Closed_By rdeutz
avatar rdeutz rdeutz - close - 25 Oct 2016
avatar rdeutz rdeutz - merge - 25 Oct 2016
avatar brianteeman brianteeman - close - 25 Oct 2016
avatar brianteeman brianteeman - change - 28 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment