User tests: Successful: Unsuccessful:
Removed unconditional return
statement from foreach loop
The method is supposed to remove all instances of element but it exits the loop on first iteration only. Looks like a quick copy-paste from removeField may have caused this.
form.xml
:<form>
<fields name="group1">
<field name="field1"/>
</fields>
<fieldset name="set1">
<fields name="group1">
<field name="field2"/>
</fields>
</fieldset>
</form>
$form = new JForm('Test');
$form->load('form.xml');
$form->removeGroup('group1');
print_r($form);
Expected:
This should remove all fields
nodes with name group1
Actual:
Only the first group is removed before patch. After patch this should remove all as expected.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
I have tested this item
We have 2 success, can it be moved forward please?
Status | Pending | ⇒ | Ready to Commit |
RTC Sorry it get missed anyhow.
Labels |
Added:
?
|
Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-25 17:40:04 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
I have tested this item✅ successfully on 3ef9036
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11856.