[#11851] - [TinyMCE] Textarea attributes
- Closed
- 14 Jan 2017
- Medium
- Build: staging
- # 11851
- Diff
- DanielvanBavel:#8106
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #8106 .
Summary of Changes
- Delete the hardcoded height value from the tinymce plugin in the tinymce.php file
- Delete the hardcoded height value from the tinymce plugin the the tinymce.xml file
Testing Instructions
Set the height you want in the tinymce plugin. Open a article and check if the height you set changed
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Plugins Front End |
That's what I was going to say. This isn't a hardcoded value. It's simply the fallback value that's used if no value is defined.
What is the reason why these values are no longer needed?
| Status | Pending | ⇒ | Information Required |
@DanielvanBavel Can you please respond to the questions above else this will be closed in a few weeks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11851.
@C-Lodder @n9iels @brianteeman I deleted the default values because in some way the values are overwrite the values that you set in the plugin. So always the xml values has priorty instead of the values in the plugin. Never you can set your own height or width
the values you deleted should be the fallback, ie, the default value if no value is set
| Title |
|
||||||
| Title |
|
||||||
(updated to a meaningful title)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11851.
@DanielvanBavel is this PR to be tested?
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-14 17:30:34 |
| Closed_By | ⇒ | DanielvanBavel |
why are you deleting the default value for the param?