Please activate JavaScript in your browser.
?
Success
Success
continuous-integration/drone
the build was successful
Details
Success
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Success
JTracker/HumanTestResults
Human Test Results: 2 Successful 0 Failed.
Details
User tests:
Successful:
Unsuccessful:
Pull Request for Improvement.
Summary of Changes
Add keepalive behaviour when edit/create a menu item to preserve the session when creating/editing a menu item.
Testing Instructions
Simple change for me only code review is needed, but for test:
Before applying patch create/edit a menu item, view html source (Ctrl + U) and check that this code (or similiar) is not there. Hint: search (Ctrl + F) for com_ajax
window .setInterval (function (){var r;try {r= window .XMLHttpRequest ? new XMLHttpRequest (): new ActiveXObject (" Microsoft.XMLHTTP" )}catch (e){}if (r){r .open (" GET" ," /administrator/index.php?option=com_ajax&format=json" ,true );r .send (null )}},840000 );
Now apply the patch
Repeat step 1 and check the code is there.
Documentation Changes Required
None.
andrepereiradasilva
-
open
-
30 Aug 2016
andrepereiradasilva
-
change
-
30 Aug 2016
joomla-cms-bot
-
change
-
30 Aug 2016
joomla-cms-bot
-
change
-
30 Aug 2016
Category
⇒
Administration
Components
andrepereiradasilva
-
change
-
30 Aug 2016
Title
Differences
…
[com_menus] Add keep alive behaviour when edit/create a menu item
[com_menus] Add keep alive behaviour when edit/create a menu item
andrepereiradasilva
-
edited
-
30 Aug 2016
andrepereiradasilva
-
change
-
31 Aug 2016
The description was changed
andrepereiradasilva
-
edited
-
31 Aug 2016
BhaveshTailored
-
test_item
-
1 Sep 2016
-
Tested successfully
AnishaTailored
-
test_item
-
6 Sep 2016
-
Tested successfully
brianteeman
-
test_item
-
6 Sep 2016
-
Tested successfully
brianteeman
-
change
-
6 Sep 2016
Status
Pending
⇒
Ready to Commit
joomla-cms-bot
-
change
-
6 Sep 2016
Status
Ready to Commit
⇒
Fixed in Code Base
Closed_Date
0000-00-00 00:00:00
⇒
2016-09-07 07:14:20
Closed_By
⇒
rdeutz
rdeutz
-
close
-
7 Sep 2016
rdeutz
-
merge
-
7 Sep 2016
joomla-cms-bot
-
close
-
7 Sep 2016
joomla-cms-bot
-
change
-
7 Sep 2016
Add a Comment
Login with GitHub to post a comment
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11849.