? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
30 Aug 2016

Pull Request for Improvement.

Summary of Changes

Add keepalive behaviour when edit/create a menu item to preserve the session when creating/editing a menu item.

Testing Instructions

Simple change for me only code review is needed, but for test:

  • Before applying patch create/edit a menu item, view html source (Ctrl + U) and check that this code (or similiar) is not there. Hint: search (Ctrl + F) for com_ajax
window.setInterval(function(){var r;try{r=window.XMLHttpRequest?new XMLHttpRequest():new ActiveXObject("Microsoft.XMLHTTP")}catch(e){}if(r){r.open("GET","/administrator/index.php?option=com_ajax&format=json",true);r.send(null)}},840000);
  • Now apply the patch
  • Repeat step 1 and check the code is there.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 30 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 30 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2016
Category Administration Components
avatar andrepereiradasilva andrepereiradasilva - change - 30 Aug 2016
Title
[com_menus] Add keep alive behaviour when edit/create a menu item
[com_menus] Add keepalive behaviour when edit/create a menu item
avatar andrepereiradasilva andrepereiradasilva - edited - 30 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 31 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 31 Aug 2016
avatar BhaveshTailored
BhaveshTailored - comment - 1 Sep 2016
avatar BhaveshTailored BhaveshTailored - test_item - 1 Sep 2016 - Tested successfully
avatar BhaveshTailored
BhaveshTailored - comment - 1 Sep 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11849.

avatar AnishaTailored AnishaTailored - test_item - 6 Sep 2016 - Tested successfully
avatar AnishaTailored
AnishaTailored - comment - 6 Sep 2016

I have tested this item successfully on 228bf69


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11849.

avatar brianteeman brianteeman - test_item - 6 Sep 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 6 Sep 2016

I have tested this item successfully on 228bf69


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11849.

avatar brianteeman brianteeman - change - 6 Sep 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 6 Sep 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11849.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 7 Sep 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-07 07:14:20
Closed_By rdeutz
avatar rdeutz rdeutz - close - 7 Sep 2016
avatar rdeutz rdeutz - merge - 7 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 7 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment