? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
29 Aug 2016

Summary of Changes

This deprecates the concrete implementation of the application class' doExecute() method in the JApplicationBase class; this was added as a B/C measure when we made the legacy JApplication class extend from here. The method is abstract in the Framework's base application class, the CMS' default classes implement this abstract method, and anyone building custom app classes should be able to implement it by 4.0.

The extended empty doExecute() methods are removed from the CLI and web application classes; it's the same as what's presently in JApplicationBase anyway.

This also notes that the base CLI and web application classes will become abstract as of 4.0. This is in line with a change that was made in the Platform before it shifted toward the Framework and matches the current declaration of the Framework classes. These two classes do not do anything useful without being extended anyway.

Testing Instructions

Code review and maintainer decision

Documentation Changes Required

N/A; all changes are documented inline.

avatar mbabker mbabker - open - 29 Aug 2016
avatar mbabker mbabker - change - 29 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Category Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 30 Aug 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-30 08:30:39
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Aug 2016
avatar wilsonge wilsonge - merge - 30 Aug 2016

Add a Comment

Login with GitHub to post a comment