? Success

User tests: Successful: Unsuccessful:

avatar esedic
esedic
29 Aug 2016

Pull Request for Issue # .

Summary of Changes

Based on these docs: https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_3_and_Joomla_Platform_12.2#JRequest JRequest is deprecated

Testing Instructions

Since I don't have a Yubikey I don't know how to test this. Only thing I could do is to set error reporting to maximum and enable the plugin. No error messages were displayed.

Documentation Changes Required

Replace deprecated JFactory::getUri() with JUri::getInstance

avatar esedic esedic - open - 29 Aug 2016
avatar esedic esedic - change - 29 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Category Plugins Front End
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Labels Added: ?
avatar esedic esedic - change - 29 Aug 2016
The description was changed
avatar esedic esedic - edited - 29 Aug 2016
avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016
  • Before Patch , I have found JFactory::getUri() in following path:-
  • /plugins/twofactorauth/totp/totp.php
  • After Patch, replace JFactory::getUri() with JUri::getInstance in above path.
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11836.
avatar bhavikTailored bhavikTailored - test_item - 29 Aug 2016 - Tested successfully
avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11836.

avatar BhaveshTailored BhaveshTailored - test_item - 29 Aug 2016 - Tested successfully
avatar BhaveshTailored
BhaveshTailored - comment - 29 Aug 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11836.

avatar wilsonge wilsonge - change - 29 Aug 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-29 13:39:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Aug 2016
avatar wilsonge wilsonge - merge - 29 Aug 2016
avatar esedic
esedic - comment - 29 Aug 2016

Just for clarification: in PR comment I've stated that JRequest is deprecated, which is true, but it isn't related to this PR.

Add a Comment

Login with GitHub to post a comment