? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Aug 2016

Generally speaking all images should have an alt tag and the alt tag must be meaningful and preferably unique for that image. Its also best practice not to use the words image or photo in the alt tag or a screen reader will end up with saying something like "image of contact image".

If you add an image to a contact then we automatically add an alt tag from the language string of "Contact Image". This fails a11y as it is neither unique to the image and contains the word image.

This simple PR changes that so the alt image is created from the Contact Name instead.

Testing Instructions

Create a contact with an image and create a menu link to it.

Before this PR the alt tag for the image will be "Contact Image"
After applying this PR the alt tag for the image will be the name of the contact

avatar brianteeman brianteeman - open - 28 Aug 2016
avatar brianteeman brianteeman - change - 28 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2016
Category Front End Components Templates (site)
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 28 Aug 2016
Category Front End Components Templates (site) Accessibility Components Front End Templates (site)
avatar brianteeman brianteeman - change - 28 Aug 2016
Easy No Yes
avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016
avatar bhavikTailored bhavikTailored - test_item - 29 Aug 2016 - Tested successfully
avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016

I have tested this item successfully on 792fddc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.

avatar BhaveshTailored
BhaveshTailored - comment - 29 Aug 2016
avatar BhaveshTailored BhaveshTailored - test_item - 29 Aug 2016 - Tested successfully
avatar BhaveshTailored
BhaveshTailored - comment - 29 Aug 2016

I have tested this item successfully on 792fddc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.

avatar killoltailored killoltailored - test_item - 29 Aug 2016 - Tested successfully
avatar killoltailored
killoltailored - comment - 29 Aug 2016

I have tested this item successfully on 792fddc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.

avatar killoltailored
killoltailored - comment - 29 Aug 2016

I have tested with Joomla! 3.6.3-dev Development [ Noether ] 5-August-2016 00:32 GMT

screen shot 2016-08-29 at 00 14 19

screen shot 2016-08-29 at 00 14 33


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.

avatar brianteeman brianteeman - change - 29 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 29 Aug 2016

Thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Labels Added: ?
avatar truptikagathara truptikagathara - test_item - 29 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 29 Aug 2016

I have tested this item successfully on 792fddc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.

avatar truptikagathara
truptikagathara - comment - 29 Aug 2016

Sorry, I do not see RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.

avatar wilsonge wilsonge - change - 29 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-29 12:35:48
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Aug 2016
avatar wilsonge wilsonge - merge - 29 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 29 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2016
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 29 Aug 2016

Thanks everyone

Add a Comment

Login with GitHub to post a comment