[#11822] - a11y improvement for contact form
- Fixed in Code Base
- 29 Aug 2016
- Medium
- Build: staging
- Easy Test
- # 11822
- Diff
- brianteeman:a11ycontact
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Generally speaking all images should have an alt tag and the alt tag must be meaningful and preferably unique for that image. Its also best practice not to use the words image or photo in the alt tag or a screen reader will end up with saying something like "image of contact image".
If you add an image to a contact then we automatically add an alt tag from the language string of "Contact Image". This fails a11y as it is neither unique to the image and contains the word image.
This simple PR changes that so the alt image is created from the Contact Name instead.
Testing Instructions
Create a contact with an image and create a menu link to it.
Before this PR the alt tag for the image will be "Contact Image"
After applying this PR the alt tag for the image will be the name of the contact
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Components Templates (site) |
| Labels |
Added:
?
|
||
| Category | Front End Components Templates (site) | ⇒ | Accessibility Components Front End Templates (site) |
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
- As per you testing Instructions before patch alt="Contact Image" and after patch alt="Contact".
- So, I have tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
I have tested with Joomla! 3.6.3-dev Development [ Noether ] 5-August-2016 00:32 GMT
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
Sorry, I do not see RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-29 12:35:48 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Thanks everyone
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11822.