I have tested this item ✅ successfully on

On code review

@dgt41 just removed some nonsense spaces in sqlazure file

I have tested this item ✅ successfully on 1061bf4

I have tested this item ✅ successfully on 1061bf4

RTC

Whst about updates? Not sure i understand why this change is being made

not needed for updates
the change is made for consistency. the language is en-GB the package is en-GB so the image is en_gb.
If you install multilanguage you also get en_gb image.

Why not needed for updates?

because we don't want to change what user selected for language image.

I understand now why you are not changing on update

But this means that a new install with no changes is different to an
install of a previous release with no changes which isn't good practice and
without any benefit

But this means that a new install with no changes is different to an install of a previous release with no changes which isn't good practice and without any benefit

and there is no problem what so ever in the current installs not having this changed.
Also that already happens in multilanguage installs.

And also this solves an spaces error in sql azure if you check the code diff.

My concern is ONLY that you are creating a difference which seems bad
practice. If you need to do this forsql azure that points to this being a
band aid and not a solution to a completely different problem

On 27 August 2016 at 19:24, andrepereiradasilva notifications@github.com
wrote:

But this means that a new install with no changes is different to an
install of a previous release with no changes which isn't good practice and
without any benefit

and there is no problem what so ever in the current installs not having
this changed.
Also that already happens in multilanguage installs.

And also this solves an spaces error in sql azure if you check the code
diff.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11815 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8dey8-xuKSpBkxh-p4ViFckHeP-5ks5qkIDNgaJpZM4JuuSb
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Isn't it the same image but only with a different name?

IMHO consistency is always important. It simplifies coding and it's good for usability.
Yes, this is a small consistency changes, but it is one.
brian this is RTC and we can agree to disagree.

Isn't it the same image but only with a different name?

Yes. The same one that a multilanguage install puts.

I am not convinced yet that this is the correct thing to do. You have now
mentioned an issue with sql azure which this supposedly fixes and this
raises concerns with me

On 27 August 2016 at 19:34, andrepereiradasilva notifications@github.com
wrote:

IMHO consistency is always important. It simplifies coding and it's good
for usability.
Yes, this is a small consistency changes, but it is one.
brian this is RTC and we can agree to disagree.

Isn't it the same image but only with a different name?

Yes. Teh same one that a multilanguage install puts.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11815 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R-ijBrQge4dMFnpVSYmAtwCoAkPks5qkINBgaJpZM4JuuSb
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

brian the sql azure thing is something i forgot to fix in #11725, so made it here to not make a new PR.

:sigh:

On 27 August 2016 at 19:46, andrepereiradasilva notifications@github.com
wrote:

brian the sql azure think is something i forgot to fix in #11725
#11725, so made it here to not
make a new PR.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11815 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WajDS98WA3A5q1q9FIlpOxGod_5ks5qkIYjgaJpZM4JuuSb
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

don't worry brian is a obvious fix - no problems at all, there were two extra spaces in the language code field.