? Success

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
27 Aug 2016

flat1

Just another take on #11789

Summary of Changes

Changes only to UI elements. Removal of background gradients. More uniform styling between template.css and chosen.css

Testing Instructions

Apply the patch and browse administration.

Documentation Changes Required

None

avatar ciar4n ciar4n - open - 27 Aug 2016
avatar ciar4n ciar4n - change - 27 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2016
Category Templates (admin) Administration
avatar dgt41
dgt41 - comment - 27 Aug 2016

@ciar4n I like it!
But the usage of custom.css is wrong. Custom.css is supposed to be used from users to further customise the template. With the current approach you are eliminating that option.
Either make a PR with the changes to #11789 or create a new PR based on #11789 with your changes and let's close #11789.

avatar ciar4n
ciar4n - comment - 27 Aug 2016

Thank you @dgt41

Admittedly I meant this as strictly a demo and hadn't considered it for anything else. I will do as you suggest. Sorry about that. I am not much practiced at both Github and the Joomla developement community.. learning slowly! :)

avatar PhilETaylor
PhilETaylor - comment - 27 Aug 2016

The grey buttons looks disabled to me. I dont like it. However I doubt design can be done by collaborative opinions though.

avatar ciar4n ciar4n - change - 28 Aug 2016
The description was changed
avatar ciar4n ciar4n - edited - 28 Aug 2016
avatar ciar4n
ciar4n - comment - 28 Aug 2016

@dgt41 I have applied the changes here but would it be better to close this PR and create a new one? I'm guessing this is something to do with the branch conflict?

@PhilETaylor Fair point on the buttons looking disabled. I bumped up the contrast on the button borders making them hopefully stand out a little more (header screenshot updated).

avatar C-Lodder
C-Lodder - comment - 28 Aug 2016

I like this too actually.

@ciar4n - If it's easier for you to create a new PR, go for it. I'd suggest creating a new branch when based on "staging", on your fork before making then changes though. Will make your life much easier if you want to submit another PR before this is merged ;)

avatar BhaveshTailored BhaveshTailored - test_item - 29 Aug 2016 - Tested successfully
avatar BhaveshTailored
BhaveshTailored - comment - 29 Aug 2016

I have tested this item successfully on 4c453bf


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11813.

avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016
avatar bhavikTailored bhavikTailored - test_item - 29 Aug 2016 - Tested successfully
avatar bhavikTailored
bhavikTailored - comment - 29 Aug 2016

I have tested this item successfully on 4c453bf


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11813.

avatar ciar4n
ciar4n - comment - 29 Aug 2016

Thank you @C-Lodder

I'll do as you suggest. Start from scratch and apply the changes to a new branch. Best start as I mean to go on :)

I'll close this PR and and create a new one once complete.

avatar ciar4n ciar4n - change - 29 Aug 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-08-29 07:20:30
Closed_By ciar4n
avatar ciar4n ciar4n - close - 29 Aug 2016

Add a Comment

Login with GitHub to post a comment