[#11804] - Allow TinyMCE plugin to be reset to default language (english)
- Fixed in Code Base
- 29 Aug 2016
- Medium
- Build: staging
- # 11804
- Diff
- jsubri:patch4
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Allow TinyMCE plugin to be reset to default language (english).
Updated the xml file to display the default value.
Testing Instructions
- Edit the TinyMCE pluging, set "Automatic Language Selection = off", select a "Language Code" such as fr, and save.
- Create a new article, the TinyMCE editor shall display the menus as per the "Language Code".
- Go back to the the TinyMCE pluging, you can't select default (english)
After the patch you can.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Plugins Front End |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11804.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11804.
This works fine but I propose to also update the language string
from
PLG_TINY_FIELD_LANGCODE_DESC="Editor UI Language. The value will be used if Automatic language is not set."
to
PLG_TINY_FIELD_LANGCODE_DESC="Editor UI Language. The value will be used if Automatic language is not set. 'Use Default' will default to English "
@brianteeman
Would that proposal be OK?
Another idea is to use this code:
<field
name="lang_code"
type="filelist"
label="PLG_TINY_FIELD_LANGCODE_LABEL"
description="PLG_TINY_FIELD_LANGCODE_DESC"
class="inputbox"
stripext="1"
directory="media/editors/tinymce/langs/"
hide_none="1"
default="en"
hide_default="1"
filter="\.js$"
size="10"
showon="lang_mode:0"
>
<option value="en">en</option>
</field>
so that we get:
What do you think?
I am not sure it needs updating at all as the tooltip is clear when you enable the option - but if you insist then
PLG_TINY_FIELD_LANGCODE_DESC="Editor UI Language. The value will be used if Automatic language is not set. 'Use Default' will default to English "
==>
PLG_TINY_FIELD_LANGCODE_DESC="Editor UI Language. The value will be used if Automatic language is not set. The Default is English."
IMHO @infograf768 's proposal is the best solution here
Indeed this is a better solution, please re test.
Thank you
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11804.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11804.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11804.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-29 17:32:32 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
the issue comes from the fact that the English language in TinyMce is not a xx.js specific file, but is included in the main js files.