Success

User tests: Successful: Unsuccessful:

avatar AmyStephen
AmyStephen
22 May 2013

Register method failed to get a copy of the Application for all uses.

avatar AmyStephen AmyStephen - open - 22 May 2013
avatar brianteeman
brianteeman - comment - 13 Oct 2013

Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.

As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta. If it is no longer valid then please can you close this issue. Otherwise please can you:

1) Open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.

avatar AmyStephen
AmyStephen - comment - 14 Oct 2013

I'm not going to have time for awhile. It's pretty easy to check -- if that single line of code I removed is still there, then, yes, it's still a bug. Sorry, just buried.

avatar Hackwar
Hackwar - comment - 5 Dec 2013

This is still a valid PR and I tested it with success. The tracker item can be found here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32897&start=0

And with the words of Cato the Elder: Ceterum censeo Joomlacode esse delendam (I believe that Joomlacode has to be destroyed. ;-) )

avatar AmyStephen
AmyStephen - comment - 5 Dec 2013

Thanks @Hackwar

avatar AmyStephen
AmyStephen - comment - 6 Dec 2013

Looks to me like the code might be okay now? It's possible it was fixed in the password patch - not sure if that will be reverted, or not, but if it is, then this should be revisited to ensure it's still okay. Otherwise, I believe it has been fixed.

Thanks, again, @Hackwar

avatar Bakual
Bakual - comment - 6 Dec 2013

Nah, code looks not ok yet. But it's RTC now, so JM will probably merge it soon :smiley:

avatar AmyStephen
AmyStephen - comment - 6 Dec 2013

Oh, I think I was looking at the Login method, not Register. Sorry about that.

Thanks again!

avatar Bakual
Bakual - comment - 6 Dec 2013

Going to merge it. Will be my first intended merge, yay!

avatar Bakual Bakual - reference | - 6 Dec 13
avatar Bakual Bakual - merge - 6 Dec 2013
avatar Bakual Bakual - close - 6 Dec 2013
avatar Bakual Bakual - change - 6 Dec 2013
Status New Closed
Closed_Date 0000-00-00 00:00:00 2013-12-06 12:44:40
Labels Added: ?
Removed: ?
avatar Bakual Bakual - close - 6 Dec 2013
avatar betweenbrain
betweenbrain - comment - 6 Dec 2013

Woo hoo! Feels good, eh?

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Dec 6, 2013 7:43 AM, "Thomas Hunziker" notifications@github.com wrote:

Going to merge it. Will be my first intended merge, yay!


Reply to this email directly or view it on GitHub#1180 (comment)
.

avatar Bakual
Bakual - comment - 6 Dec 2013

Better than the accidental merge lately for sure :smile:

avatar AmyStephen
AmyStephen - comment - 6 Dec 2013

Wow - that's kind of an honor to have @Bakual perform his first official merge with your teeny little patch!

Thanks -- and again, thanks @Hackwar for getting this going.

Add a Comment

Login with GitHub to post a comment