[#11787] - Fix enter key triggering cancel button on forms
- Fixed in Code Base
- 25 Aug 2016
- Medium
- Build: staging
- # 11787
- Diff
- dgt41:fixModalsCloseOnEnter
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 5 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11765 .
Summary of Changes
Change button tag to a
Testing Instructions
Create a new article
Add an article title
Click the alias field (or any text field), add text (or not).
Hit 'enter' key
Before patch
Article is cancelled, navigating back to article manager.
After patch
Nothing
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Media Manager Tags Modules Templates (admin) Templates (site) Front End |
| Labels |
Added:
?
|
||
I have tested this item
Also tested in IE8 to see if it threw a hissy fit due to no href being used...all working and good to go.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11787.
In HTML5 there's no need. If the href attribute isn't present, it acts as a placeholder.
I have tested this item
thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11787.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11787.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11787.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 20:27:09 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 295b125
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11787.